Update to wasmtime 34 (#471)

* Update to wasmtime 34

* Clippy and fmt

Author: saulecabrera

Cargo.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    wasmtime (33.0.0)
+    wasmtime (34.0.0)
       rb_sys (~> 0.9.108)
 
 GEM

Gemfile.lock

@@ -24,8 +24,8 @@ magnus = { version = "0.7", features = ["rb-sys"] }
 rb-sys = { version = "*", default-features = false, features = [
   "stable-api-compiled-fallback",
 ] }
-wasmtime = { version = "=33.0.0", features = ["memory-protection-keys"] }
-wasmtime-wasi = "=33.0.0"
+wasmtime = { version = "=34.0.0", features = ["memory-protection-keys"] }
+wasmtime-wasi = "=34.0.0"
 cap-std = "3.4.0"
 wat = "1.227.1"
 tokio = { version = "1.40.0", features = [
@@ -38,8 +38,8 @@ async-timer = { version = "1.0.0-beta.15", features = [
   "tokio1",
 ], optional = true }
 static_assertions = "1.1.0"
-wasmtime-environ = "=33.0.0"
-deterministic-wasi-ctx = { version = "=1.2.1" }
+wasmtime-environ = "=34.0.0"
+deterministic-wasi-ctx = { version = "=3.0.0" }
 
 [build-dependencies]
 rb-sys-env = "0.2.2"

ext/Cargo.toml

@@ -20,6 +20,10 @@ impl<'a> CallerHandle<'a> {
         }
     }
 
+    // Note that the underlying implemenation relies on `UnsafeCell`, which
+    // provides some gurantees around interior mutability, therefore we're
+    // opting to allow this lint.
+    #[allow(clippy::mut_from_ref)]
     pub fn get_mut(&self) -> Result<&mut CallerImpl<'a, StoreData>, Error> {
         unsafe { &mut *self.caller.get() }
             .as_mut()

ext/src/ruby_api/caller.rs

@@ -49,7 +49,7 @@ pub(crate) fn component_val_to_rb(val: Val, _store: &StoreContextValue) -> Resul
             let hash = RHash::new();
             for (name, val) in fields {
                 let rb_value = component_val_to_rb(val, _store)
-                    .map_err(|e| e.append(format!(" (struct field \"{}\")", name)))?;
+                    .map_err(|e| e.append(format!(" (struct field \"{name}\")")))?;
                 hash.aset(name.as_str(), rb_value)?
             }
 
@@ -138,7 +138,7 @@ pub(crate) fn rb_to_component_val(
             // user code so user code can't mutate it either.
             for (i, value) in unsafe { rarray.as_slice() }.iter().enumerate() {
                 let component_val = rb_to_component_val(*value, _store, &ty)
-                    .map_err(|e| e.append(format!(" (list item at index {})", i)))?;
+                    .map_err(|e| e.append(format!(" (list item at index {i})")))?;
 
                 vals.push(component_val);
             }
@@ -180,7 +180,7 @@ pub(crate) fn rb_to_component_val(
 
             for (i, (ty, value)) in types.zip(unsafe { rarray.as_slice() }.iter()).enumerate() {
                 let component_val = rb_to_component_val(*value, _store, &ty)
-                    .map_err(|error| error.append(format!(" (tuple value at index {})", i)))?;
+                    .map_err(|error| error.append(format!(" (tuple value at index {i})")))?;
 
                 vals.push(component_val);
             }

ext/src/ruby_api/component/convert.rs

@@ -142,7 +142,7 @@ fn convert_params(
             .map_err(|_| Error::new(arg_error(), "too many params"))?;
 
         let component_val = rb_to_component_val(*value, store, &ty.1)
-            .map_err(|error| error.append(format!(" (param at index {})", i)))?;
+            .map_err(|error| error.append(format!(" (param at index {i})")))?;
 
         params.push(component_val);
     }

ext/src/ruby_api/component/func.rs

@@ -119,7 +119,7 @@ pub fn hash_to_config(hash: RHash) -> Result<Config, Error> {
 
             if let Some(target) = target {
                 config.target(&target).map_err(|e| {
-                    Error::new(arg_error(), format!("Invalid target: {}: {}", target, e))
+                    Error::new(arg_error(), format!("Invalid target: {target}: {e}"))
                 })?;
             }
         } else if *GENERATE_ADDRESS_MAP == id {

ext/src/ruby_api/config.rs

@@ -235,8 +235,7 @@ impl PoolingAllocationConfig {
         let inner = format!("{:?}", rb_self.borrow_mut()?);
 
         Ok(format!(
-            "#<Wasmtime::PoolingAllocationConfig inner={}>",
-            inner
+            "#<Wasmtime::PoolingAllocationConfig inner={inner}>"
         ))
     }
 

ext/src/ruby_api/pooling_allocation_config.rs

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Wasmtime
-  VERSION = "33.0.0"
+  VERSION = "34.0.0"
 end