Deduplicate static/dynamic host function code paths (#12146)

* Deduplicate static/dynamic host function code paths

This commit refactors the `component/func/host.rs` file to deduplicate
the paths between static/dynamic host functions. Previously there was a
significant amount of duplication between the two which has been
exacerbated through time. This commit refactors the state of affairs to
ensure that all the shared logic between the two is in one location and
the only difference is what they're already doing different (e.g.
lifting/lowering guts).

The high-level goal here was to see if this was possible, but in the end
this feels like a much cleaner state of affairs than prior as far fewer
details are duplicated across a few locations. The host function
behavior is slightly more "dynamic" than before in the sense that
statically-known signature has a few more type lookups than before, for
example, but this can be fixed in due time if necessary.

* Fix compile warnings/issues

Author: alexcrichton

crates/wasmtime/src/runtime/component/concurrent.rs

@@ -82,8 +82,8 @@ use std::vec::Vec;
 use table::{TableDebug, TableId};
 use wasmtime_environ::Trap;
 use wasmtime_environ::component::{
-    CanonicalOptions, CanonicalOptionsDataModel, ExportIndex, MAX_FLAT_PARAMS, MAX_FLAT_RESULTS,
-    OptionsIndex, PREPARE_ASYNC_NO_RESULT, PREPARE_ASYNC_WITH_RESULT,
+    CanonicalAbiInfo, CanonicalOptions, CanonicalOptionsDataModel, ExportIndex, MAX_FLAT_PARAMS,
+    MAX_FLAT_RESULTS, OptionsIndex, PREPARE_ASYNC_NO_RESULT, PREPARE_ASYNC_WITH_RESULT,
     RuntimeComponentInstanceIndex, RuntimeTableIndex, StringEncoding,
     TypeComponentGlobalErrorContextTableIndex, TypeComponentLocalErrorContextTableIndex,
     TypeFuncIndex, TypeFutureTableIndex, TypeStreamTableIndex, TypeTupleIndex,
@@ -2519,7 +2519,7 @@ impl Instance {
     /// stack and linear memory unless the task has been cancelled.
     pub(crate) fn first_poll<T: 'static, R: Send + 'static>(
         self,
-        mut store: StoreContextMut<T>,
+        mut store: StoreContextMut<'_, T>,
         future: impl Future<Output = Result<R>> + Send + 'static,
         caller_instance: RuntimeComponentInstanceIndex,
         lower: impl FnOnce(StoreContextMut<T>, R) -> Result<()> + Send + 'static,
@@ -3279,8 +3279,11 @@ impl Instance {
                     }
                 };
                 let memory = self.options_memory_mut(store, params.options);
-                let ptr =
-                    func::validate_inbounds::<(u32, u32)>(memory, &ValRaw::u32(params.payload))?;
+                let ptr = func::validate_inbounds_dynamic(
+                    &CanonicalAbiInfo::POINTER_PAIR,
+                    memory,
+                    &ValRaw::u32(params.payload),
+                )?;
                 memory[ptr + 0..][..4].copy_from_slice(&handle.to_le_bytes());
                 memory[ptr + 4..][..4].copy_from_slice(&result.to_le_bytes());
                 Ok(ordinal)

crates/wasmtime/src/runtime/component/concurrent_disabled.rs

@@ -4,11 +4,8 @@ use crate::component::{ComponentType, Lift, Lower, Val};
 use crate::runtime::vm::VMStore;
 use anyhow::{Result, anyhow, bail};
 use core::convert::Infallible;
-use core::future::Future;
 use core::mem::MaybeUninit;
-use core::pin::pin;
-use core::task::{Context, Poll, Waker};
-use wasmtime_environ::component::{CanonicalAbiInfo, InterfaceType, RuntimeComponentInstanceIndex};
+use wasmtime_environ::component::{CanonicalAbiInfo, InterfaceType};
 
 #[derive(Default)]
 pub struct ConcurrentState;
@@ -26,17 +23,6 @@ pub(crate) fn check_blocking(_: &mut dyn VMStore) -> Result<()> {
     Ok(())
 }
 
-pub(crate) fn poll_and_block<R: Send + Sync + 'static>(
-    _store: &mut dyn VMStore,
-    future: impl Future<Output = Result<R>> + Send + 'static,
-    _caller_instance: RuntimeComponentInstanceIndex,
-) -> Result<R> {
-    match pin!(future).poll(&mut Context::from_waker(Waker::noop())) {
-        Poll::Ready(result) => result,
-        Poll::Pending => should_have_failed_validation("async lowered import"),
-    }
-}
-
 pub(crate) fn lower_error_context_to_index<U>(
     _rep: u32,
     _cx: &mut LowerContext<'_, U>,