Skip to content

Commit 0a3aea3

Browse files
authored
Tighten up assertions for basic-gvn test. (#10186)
Assert that the v4 assignment is gone. Assert that nothing appears before the v2 assignment, as that would be a surprise worth hearing about.
1 parent 99622ab commit 0a3aea3

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

cranelift/filetests/filetests/egraph/basic-gvn.clif

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,9 @@ block2(v6: i32):
1919
;; Check that the `iadd` for `v4` is subsumed by `v2`:
2020

2121
; check: block0(v0: i32, v1: i32):
22-
; check: v2 = iadd v0, v1
22+
; nextln: v2 = iadd v0, v1
2323
; check: block1:
24-
; check: v5 = iadd.i32 v2, v0
24+
; nextln: v5 = iadd.i32 v2, v0
2525
; nextln: return v5
2626
; check: block2:
2727
; nextln: return v1

cranelift/isle/isle/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,4 +6,4 @@ clif instructions to vcode's `MachInst`s in Cranelift.
66
ISLE is a statically-typed term-rewriting language. You define rewriting rules
77
that map input terms (clif instructions) into output terms (`MachInst`s). These
88
rules get compiled down into Rust source test that uses a tree of `match`
9-
expressions that is as good or better than what you would have written by hand.
9+
expressions as good as or better than what you would have written by hand.

0 commit comments

Comments
 (0)