Skip to content

Commit 89419ec

Browse files
authored
winch: Move the AtomicWaitKind definition to the MacroAssembler (#10853)
This commit is a small refactoring which moves the definition of the `AtomicWaitKind` enum to the `MacroAssembler`, to ensure with the other operation kind definitions.
1 parent 910ab3f commit 89419ec

File tree

3 files changed

+18
-17
lines changed

3 files changed

+18
-17
lines changed

winch/codegen/src/codegen/mod.rs

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,9 @@ use crate::{
33
codegen::BlockSig,
44
isa::reg::{Reg, writable},
55
masm::{
6-
Extend, Imm, IntCmpKind, LaneSelector, LoadKind, MacroAssembler, OperandSize, RegImm,
7-
RmwOp, SPOffset, ShiftKind, StoreKind, TrapCode, UNTRUSTED_FLAGS, Zero,
6+
AtomicWaitKind, Extend, Imm, IntCmpKind, LaneSelector, LoadKind, MacroAssembler,
7+
OperandSize, RegImm, RmwOp, SPOffset, ShiftKind, StoreKind, TrapCode, UNTRUSTED_FLAGS,
8+
Zero,
89
},
910
stack::TypedReg,
1011
};
@@ -83,13 +84,6 @@ pub(crate) struct SourceLocation {
8384
pub current: (CodeOffset, RelSourceLoc),
8485
}
8586

86-
/// Represents the `memory.atomic.wait*` kind.
87-
#[derive(Debug, Clone, Copy)]
88-
pub(crate) enum AtomicWaitKind {
89-
Wait32,
90-
Wait64,
91-
}
92-
9387
/// The code generation abstraction.
9488
pub(crate) struct CodeGen<'a, 'translation: 'a, 'data: 'translation, M, P>
9589
where

winch/codegen/src/masm.rs

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,13 @@ pub(crate) enum DivKind {
2323
Unsigned,
2424
}
2525

26+
/// Represents the `memory.atomic.wait*` kind.
27+
#[derive(Debug, Clone, Copy)]
28+
pub(crate) enum AtomicWaitKind {
29+
Wait32,
30+
Wait64,
31+
}
32+
2633
/// Remainder kind.
2734
#[derive(Copy, Clone)]
2835
pub(crate) enum RemKind {

winch/codegen/src/visitor.rs

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -6,16 +6,16 @@
66
77
use crate::abi::RetArea;
88
use crate::codegen::{
9-
AtomicWaitKind, Callee, CodeGen, CodeGenError, ConditionalBranch, ControlStackFrame, Emission,
10-
FnCall, UnconditionalBranch, control_index,
9+
Callee, CodeGen, CodeGenError, ConditionalBranch, ControlStackFrame, Emission, FnCall,
10+
UnconditionalBranch, control_index,
1111
};
1212
use crate::masm::{
13-
DivKind, Extend, ExtractLaneKind, FloatCmpKind, IntCmpKind, LoadKind, MacroAssembler,
14-
MulWideKind, OperandSize, RegImm, RemKind, ReplaceLaneKind, RmwOp, RoundingMode, SPOffset,
15-
ShiftKind, Signed, SplatKind, SplatLoadKind, StoreKind, TruncKind, V128AbsKind, V128AddKind,
16-
V128ConvertKind, V128ExtAddKind, V128ExtMulKind, V128ExtendKind, V128LoadExtendKind,
17-
V128MaxKind, V128MinKind, V128MulKind, V128NarrowKind, V128NegKind, V128SubKind, V128TruncKind,
18-
VectorCompareKind, VectorEqualityKind, Zero,
13+
AtomicWaitKind, DivKind, Extend, ExtractLaneKind, FloatCmpKind, IntCmpKind, LoadKind,
14+
MacroAssembler, MulWideKind, OperandSize, RegImm, RemKind, ReplaceLaneKind, RmwOp,
15+
RoundingMode, SPOffset, ShiftKind, Signed, SplatKind, SplatLoadKind, StoreKind, TruncKind,
16+
V128AbsKind, V128AddKind, V128ConvertKind, V128ExtAddKind, V128ExtMulKind, V128ExtendKind,
17+
V128LoadExtendKind, V128MaxKind, V128MinKind, V128MulKind, V128NarrowKind, V128NegKind,
18+
V128SubKind, V128TruncKind, VectorCompareKind, VectorEqualityKind, Zero,
1919
};
2020

2121
use crate::reg::{Reg, writable};

0 commit comments

Comments
 (0)