Skip to content

Commit a5fc046

Browse files
authored
wasmtime: Add Android AArch64 Check (#5507)
We accidentally broke the build for Android when introducing the jit-icache-coherence crate. To avoid this happening again, add a check job just to ensure that it can build. See #5323 and #5331 for context.
1 parent 6d24de7 commit a5fc046

File tree

1 file changed

+14
-0
lines changed

1 file changed

+14
-0
lines changed

.github/workflows/main.yml

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -135,6 +135,8 @@ jobs:
135135
checks:
136136
name: Check
137137
runs-on: ubuntu-latest
138+
env:
139+
CARGO_NDK_VERSION: 2.12.2
138140
steps:
139141
- uses: actions/checkout@v3
140142
with:
@@ -177,6 +179,18 @@ jobs:
177179
- run: rustup target add x86_64-unknown-freebsd
178180
- run: cargo check -p wasmtime --no-default-features --features cranelift,wat,async,cache --target x86_64-unknown-freebsd
179181

182+
# Check whether `wasmtime` cross-compiles to aarch64-linux-android
183+
- run: rustup target add aarch64-linux-android
184+
- name: Setup Android SDK
185+
uses: android-actions/setup-android@v2
186+
- uses: actions/cache@v3
187+
with:
188+
path: ${{ runner.tool_cache }}/cargo-ndk
189+
key: cargo-ndk-bin-${{ env.CARGO_NDK_VERSION }}
190+
- run: echo "${{ runner.tool_cache }}/cargo-ndk/bin" >> $GITHUB_PATH
191+
- run: cargo install --root ${{ runner.tool_cache }}/cargo-ndk --version ${{ env.CARGO_NDK_VERSION }} cargo-ndk
192+
- run: cargo ndk -t arm64-v8a check -p wasmtime
193+
180194
# Check whether `wasmtime` cross-compiles to aarch64-pc-windows-msvc
181195
# We don't build nor test it because it lacks trap handling.
182196
# Tracking issue: https://github.com/bytecodealliance/wasmtime/issues/4992

0 commit comments

Comments
 (0)