Add cranelift fcmp ult, ule, ugt, uge for aarch64 (#12196)

* Run cranelift fcmp ord and uno tests on aarch64

FloatCC::Ordered and FloatCC:Unordered are already implemented for
aarch64, so these can be enabled as they already pass.

* Run more cranelift fcmp tests on aarch64

These currently fail as they are not implemented yet.

* Add cranelift fcmp ult, ule, ugt, uge for aarch64

Author: tobil4sk

cranelift/codegen/src/isa/aarch64/lower.rs

@@ -97,14 +97,14 @@ pub(crate) fn lower_fp_condcode(cc: FloatCC) -> Cond {
         FloatCC::GreaterThan => Cond::Gt,
         // GT | EQ. Ge => N = V.
         FloatCC::GreaterThanOrEqual => Cond::Ge,
-        // UN | LT
-        FloatCC::UnorderedOrLessThan => unimplemented!(),
-        // UN | LT | EQ
-        FloatCC::UnorderedOrLessThanOrEqual => unimplemented!(),
-        // UN | GT
-        FloatCC::UnorderedOrGreaterThan => unimplemented!(),
-        // UN | GT | EQ
-        FloatCC::UnorderedOrGreaterThanOrEqual => unimplemented!(),
+        // UN | LT. Lt => N != V.
+        FloatCC::UnorderedOrLessThan => Cond::Lt,
+        // UN | LT | EQ. Le => not (Z clear, N = V).
+        FloatCC::UnorderedOrLessThanOrEqual => Cond::Le,
+        // UN | GT. Hi => C set, Z clear.
+        FloatCC::UnorderedOrGreaterThan => Cond::Hi,
+        // UN | GT | EQ. Pl => N clear.
+        FloatCC::UnorderedOrGreaterThanOrEqual => Cond::Pl,
     }
 }
 

cranelift/filetests/filetests/runtests/fcmp-ord.clif

@@ -2,6 +2,7 @@ test interpret
 test run
 target x86_64
 target x86_64 has_avx
+target aarch64
 target s390x
 target riscv64
 target riscv64 has_c has_zcb

cranelift/filetests/filetests/runtests/fcmp-uge.clif

@@ -2,6 +2,7 @@ test interpret
 test run
 target x86_64
 target x86_64 has_avx
+target aarch64
 target s390x
 target riscv64
 target riscv64 has_c has_zcb

cranelift/filetests/filetests/runtests/fcmp-ugt.clif

@@ -2,6 +2,7 @@ test interpret
 test run
 target x86_64
 target x86_64 has_avx
+target aarch64
 target s390x
 target riscv64
 target riscv64 has_c has_zcb

cranelift/filetests/filetests/runtests/fcmp-ule.clif

@@ -2,6 +2,7 @@ test interpret
 test run
 target x86_64
 target x86_64 has_avx
+target aarch64
 target s390x
 target riscv64
 target riscv64 has_c has_zcb

cranelift/filetests/filetests/runtests/fcmp-ult.clif

@@ -2,6 +2,7 @@ test interpret
 test run
 target x86_64
 target x86_64 has_avx
+target aarch64
 target s390x
 target riscv64
 target riscv64 has_c has_zcb

cranelift/filetests/filetests/runtests/fcmp-uno.clif

@@ -2,6 +2,7 @@ test interpret
 test run
 target x86_64
 target x86_64 has_avx
+target aarch64
 target s390x
 target riscv64
 target riscv64 has_c has_zcb

cranelift/fuzzgen/src/function_generator.rs

@@ -199,10 +199,6 @@ fn insert_cmp(
             // https://github.com/bytecodealliance/wasmtime/issues/4850
             (Architecture::Aarch64(_), FloatCC::OrderedNotEqual) => true,
             (Architecture::Aarch64(_), FloatCC::UnorderedOrEqual) => true,
-            (Architecture::Aarch64(_), FloatCC::UnorderedOrLessThan) => true,
-            (Architecture::Aarch64(_), FloatCC::UnorderedOrLessThanOrEqual) => true,
-            (Architecture::Aarch64(_), FloatCC::UnorderedOrGreaterThan) => true,
-            (Architecture::Aarch64(_), FloatCC::UnorderedOrGreaterThanOrEqual) => true,
 
             // These are not implemented on x86_64, for vectors.
             (Architecture::X86_64, FloatCC::UnorderedOrEqual | FloatCC::OrderedNotEqual) => {