feat: linting

Signed-off-by: Andrew Steurer <94206073+asteurer@users.noreply.github.com>

Author: asteurer

.devcontainer/setup.sh

@@ -27,3 +27,8 @@ echo "export PATH=$DOTNET_PATH:\$PATH" >> ~/.bashrc
 # Moonbit
 curl -fsSL https://cli.moonbitlang.com/install/unix.sh | bash
 echo 'export PATH="$HOME/.moon/bin:$PATH"' >> ~/.bashrc
+
+# Go
+curl -OL https://go.dev/dl/go1.25.5.linux-amd64.tar.gz
+tar xf go1.25.5.linux-amd64.tar.gz
+echo "export PATH=$HOME/go1.25.5.linux-amd64/bin:\$PATH" >> ~/.bashrc

.github/actions/install-rust/action.yml

@@ -0,0 +1,73 @@
+name: 'Install Rust toolchain'
+description: 'Install a rust toolchain'
+
+inputs:
+  toolchain:
+    description: 'Default toolchan to install'
+    required: false
+    default: 'stable'
+
+runs:
+  using: composite
+  steps:
+    - name: Install Rust
+      shell: bash
+      id: select
+      run: |
+        # Determine MSRV as N in `1.N.0` by looking at the `rust-version`
+        # located in the root `Cargo.toml`.
+        msrv=$(grep 'rust-version.*1' Cargo.toml | sed 's/.*\.\([0-9]*\)\..*/\1/')
+
+        if [ "${{ inputs.toolchain }}" = "msrv" ]; then
+          echo "version=1.$msrv.0" >> "$GITHUB_OUTPUT"
+        else
+          echo "version=${{ inputs.toolchain }}" >> "$GITHUB_OUTPUT"
+        fi
+
+    - name: Install Rust
+      shell: bash
+      run: |
+        rustup set profile minimal
+        rustup update "${{ steps.select.outputs.version }}" --no-self-update
+        rustup default "${{ steps.select.outputs.version }}"
+
+        # Save disk space by avoiding incremental compilation. Also turn down
+        # debuginfo from 2 to 0 to help save disk space.
+        cat >> "$GITHUB_ENV" <<EOF
+        CARGO_INCREMENTAL=0
+        CARGO_PROFILE_DEV_DEBUG=0
+        CARGO_PROFILE_TEST_DEBUG=0
+        EOF
+
+        # Deny warnings on CI to keep our code warning-free as it lands in-tree.
+        echo RUSTFLAGS="-D warnings" >> "$GITHUB_ENV"
+
+    - run: rustup target add wasm32-wasip2
+      if: inputs.toolchain != 'msrv'
+      shell: bash
+
+    - run: |
+        curl -L -o wasi-sdk.tar.gz https://github.com/WebAssembly/wasi-sdk/releases/download/wasi-sdk-27/wasi-sdk-27.0-x86_64-linux.tar.gz
+        tar xf wasi-sdk.tar.gz
+        echo "WASI_SDK_PATH=`pwd`/wasi-sdk-27.0-x86_64-linux" >> $GITHUB_ENV
+      if: runner.os == 'Linux'
+      shell: bash
+      working-directory: ${{ runner.tool_cache }}
+    - run: |
+        curl -L -o wasi-sdk.tar.gz https://github.com/WebAssembly/wasi-sdk/releases/download/wasi-sdk-27/wasi-sdk-27.0-x86_64-macos.tar.gz
+        tar xf wasi-sdk.tar.gz
+        echo "WASI_SDK_PATH=`pwd`/wasi-sdk-27.0-x86_64-macos" >> $GITHUB_ENV
+      if: runner.os == 'macOS'
+      shell: bash
+      working-directory: ${{ runner.tool_cache }}
+    - run: |
+        curl -L -o wasi-sdk.tar.gz https://github.com/WebAssembly/wasi-sdk/releases/download/wasi-sdk-27/wasi-sdk-27.0-x86_64-windows.tar.gz
+        tar xf wasi-sdk.tar.gz
+        echo "WASI_SDK_PATH=`pwd`/wasi-sdk-27.0-x86_64-windows" >> $GITHUB_ENV
+      if: runner.os == 'Windows'
+      shell: bash
+      working-directory: ${{ runner.tool_cache }}
+    - name: Setup `wasmtime`
+      uses: bytecodealliance/actions/wasmtime/setup@v1
+      with:
+        version: "v40.0.0"

.github/workflows/main.yml

@@ -114,7 +114,7 @@ jobs:
     # Run all runtime tests for this language, and also enable Rust in case this
     # language only implements either the runner or test component
     - run: |
-        cargo run test --languages rust,${{ matrix.lang }} tests/runtime \
+        cargo run test --languages ${{ matrix.lang }} tests/runtime \
           --artifacts target/artifacts \
           --rust-wit-bindgen-path ./crates/guest-rust
 
@@ -262,3 +262,11 @@ jobs:
     - name: Report failure on cancellation
       if: ${{ contains(needs.*.result, 'cancelled') || cancelled() }}
       run: exit 1
+
+  clippy:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v6
+      - uses: ./.github/actions/install-rust
+      - run: rustup component add clippy
+      - run: cargo clippy --workspace --all-targets

Cargo.toml

@@ -11,6 +11,9 @@ description = """
 CLI tool to generate bindings for WIT documents and the component model.
 """
 
+[lints]
+workspace = true
+
 [workspace]
 resolver = "2"
 
@@ -52,6 +55,21 @@ wit-bindgen-go = { path = 'crates/go', version = '0.50.0' }
 wit-bindgen = { path = 'crates/guest-rust', version = '0.50.0', default-features = false }
 wit-bindgen-test = { path = 'crates/test', version = '0.50.0' }
 
+[workspace.lints.clippy]
+# The default set of lints in Clippy is viewed as "too noisy" right now so
+# they're all turned off by default. Selective lints are then enabled below as
+# necessary.
+all = { level = 'allow', priority = -1 }
+clone_on_copy = 'warn'
+map_clone = 'warn'
+unnecessary_to_owned = 'warn'
+manual_strip = 'warn'
+uninlined_format_args = 'warn'
+unnecessary_mut_passed = 'warn'
+unnecessary_fallible_conversions = 'warn'
+unnecessary_cast = 'warn'
+allow_attributes_without_reason = 'warn'
+
 [[bin]]
 name = "wit-bindgen"