fix(go, c): escape ret and err (#774)

* fix(go, c): escape ret and err

Signed-off-by: Jiaxiao Zhou (Mossaka) <[email protected]>

* added the test case

Signed-off-by: Jiaxiao Zhou (Mossaka) <[email protected]>

* skip go_params test in C#

Signed-off-by: Jiaxiao Zhou (Mossaka) <[email protected]>

* rustfmt

Signed-off-by: Jiaxiao Zhou (Mossaka) <[email protected]>

---------

Signed-off-by: Jiaxiao Zhou (Mossaka) <[email protected]>

Author: Mossaka

crates/c/src/lib.rs

@@ -2833,6 +2833,10 @@ pub fn to_c_ident(name: &str) -> String {
         "xor" => "xor_".into(),
         "xor_eq" => "xor_eq_".into(),
         "_Packed" => "_Packed_".into(),
+        // ret and err needs to be escaped because they are used as
+        //  variable names for option and result flattening.
+        "ret" => "ret_".into(),
+        "err" => "err_".into(),
         s => s.to_snake_case(),
     }
 }

crates/csharp/tests/codegen.rs

@@ -63,6 +63,7 @@ macro_rules! codegen_test {
                         "variants",
                         "worlds-with-types",
                         "zero-size-tuple",
+                        "go_params",
                     ]
                     .contains(&$name)
                     {

crates/go/src/interface.rs

@@ -433,7 +433,7 @@ impl InterfaceGenerator<'_> {
                 if is_pointer {
                     prefix.push_str("&");
                 }
-                if name != "err" && name != "ret" {
+                if name != "ret" {
                     param_name = format!("lower_{name}");
                 } else {
                     param_name.push_str(name);

crates/go/src/lib.rs

@@ -362,7 +362,7 @@ fn avoid_keyword(s: &str) -> String {
 }
 
 // a list of Go keywords
-const GOKEYWORDS: [&str; 25] = [
+const GOKEYWORDS: [&str; 26] = [
     "break",
     "default",
     "func",
@@ -388,4 +388,7 @@ const GOKEYWORDS: [&str; 25] = [
     "import",
     "return",
     "var",
+    // not a Go keyword but needs to escape due to
+    // it's used as a variable name that passes to C
+    "ret",
 ];

tests/codegen/go_params.wit

@@ -0,0 +1,8 @@
+package foo:foo;
+
+world go-params {
+    import error-code: func(err: u32) -> option<u32>;
+    import error-code2: func(ret: u32) -> option<u32>;
+    import error-code3: func(err: u32, ret: option<u32>) -> result<u32>;
+    import error-code4: func() -> result<u32>;
+}