Skip to content

Commit ef00821

Browse files
authored
disable Java tests on Windows (#497)
Per #495, Maven has started failing to resolve dependencies on Windows in the GitHub action, although it works fine on Mac, Linux, and also (locally) on Windows. For the time being, I'm disabling these tests so the failures are not a distraction while we determine a proper solution. Signed-off-by: Joel Dice <[email protected]>
1 parent b0b9e45 commit ef00821

File tree

2 files changed

+21
-2
lines changed

2 files changed

+21
-2
lines changed

crates/gen-guest-teavm-java/tests/codegen.rs

Lines changed: 15 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
use heck::{ToSnakeCase, ToUpperCamelCase};
2-
use std::fs;
31
use std::path::Path;
42
use std::process::Command;
53

@@ -24,7 +22,22 @@ macro_rules! codegen_test {
2422
}
2523
test_helpers::codegen_tests!("*.wit");
2624

25+
// TODO: As of this writing, Maven has started failing to resolve dependencies on Windows in the GitHub action,
26+
// apparently unrelated to any code changes we've made. Until we've either resolved the problem or developed a
27+
// workaround, we're disabling the tests.
28+
//
29+
// See https://github.com/bytecodealliance/wit-bindgen/issues/495 for more information.
30+
#[cfg(windows)]
31+
fn verify(_dir: &Path, _name: &str) {
32+
_ = mvn;
33+
_ = pom_xml;
34+
}
35+
36+
#[cfg(unix)]
2737
fn verify(dir: &Path, name: &str) {
38+
use heck::{ToSnakeCase, ToUpperCamelCase};
39+
use std::fs;
40+
2841
let java_dir = &dir.join("src/main/java");
2942
let snake = name.to_snake_case();
3043
let package_dir = &java_dir.join(format!("wit_{snake}"));

tests/runtime/main.rs

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -206,6 +206,12 @@ fn tests(name: &str) -> Result<Vec<PathBuf>> {
206206
result.push(component_path);
207207
}
208208

209+
// TODO: As of this writing, Maven has started failing to resolve dependencies on Windows in the GitHub action,
210+
// apparently unrelated to any code changes we've made. Until we've either resolved the problem or developed a
211+
// workaround, we're disabling the tests.
212+
//
213+
// See https://github.com/bytecodealliance/wit-bindgen/issues/495 for more information.
214+
#[cfg(unix)]
209215
#[cfg(feature = "teavm-java")]
210216
if !java.is_empty() {
211217
use heck::*;

0 commit comments

Comments
 (0)