more fixed size implementation

Author: cpetig

crates/c/src/lib.rs

@@ -1457,6 +1457,10 @@ impl<'a> wit_bindgen_core::AnonymousTypeGenerator<'a> for InterfaceGenerator<'a>
     fn anonymous_type_type(&mut self, _id: TypeId, _ty: &Type, _docs: &Docs) {
         todo!("print_anonymous_type for type");
     }
+    
+    fn anonymous_type_fixed_size_list(&mut self, _id: TypeId, _ty: &Type, _size: u32, _docs: &Docs) {
+        todo!("print_anonymous_type for fixed size list");
+    }
 }
 
 pub enum CTypeNameInfo<'a> {

crates/core/src/abi.rs

@@ -307,6 +307,21 @@ def_instruction! {
             ty: TypeId,
         } : [2] => [1],
 
+        /// Pops all fields for a fixed list off the stack and then composes them
+        /// into an array.
+        FixedSizeListLift {
+            elements: &'a Type,
+            size: u32,
+            id: TypeId,
+        } : [*size as usize] => [1],
+
+        /// Pops an array off the stack, decomposes the elements and then pushes them onto the stack.
+        FixedSizeListLower {
+            elements: &'a Type,
+            size: u32,
+            id: TypeId,
+        } : [1] => [*size as usize],
+
         /// Pushes an operand onto the stack representing the list item from
         /// each iteration of the list.
         ///
@@ -1550,7 +1565,21 @@ impl<'a, B: Bindgen> Generator<'a, B> {
                     });
                 }
                 TypeDefKind::Unknown => unreachable!(),
-                TypeDefKind::FixedSizeList(_, _) => todo!(),
+                TypeDefKind::FixedSizeList(ty, size) => {
+                    let mut temp = Vec::new();
+                    self.resolve.push_flat(&Type::Id(id), &mut temp);
+                    let mut args = self
+                        .stack
+                        .drain(self.stack.len() - temp.len()..)
+                        .collect::<Vec<_>>();
+                    for _ in 0..*size {
+                        temp.truncate(0);
+                        self.resolve.push_flat(ty, &mut temp);
+                        self.stack.extend(args.drain(..temp.len()));
+                        self.lift(ty);
+                    }
+                    self.emit(&FixedSizeListLift { elements: ty, size: *size, id });
+                }
             },
         }
     }

crates/core/src/lib.rs

@@ -193,6 +193,7 @@ pub trait AnonymousTypeGenerator<'a> {
     fn anonymous_type_option(&mut self, id: TypeId, ty: &Type, docs: &Docs);
     fn anonymous_type_result(&mut self, id: TypeId, ty: &Result_, docs: &Docs);
     fn anonymous_type_list(&mut self, id: TypeId, ty: &Type, docs: &Docs);
+    fn anonymous_type_fixed_size_list(&mut self, id: TypeId, ty: &Type, size: u32, docs: &Docs);
     fn anonymous_type_future(&mut self, id: TypeId, ty: &Option<Type>, docs: &Docs);
     fn anonymous_type_stream(&mut self, id: TypeId, ty: &Option<Type>, docs: &Docs);
     fn anonymous_type_type(&mut self, id: TypeId, ty: &Type, docs: &Docs);
@@ -216,7 +217,7 @@ pub trait AnonymousTypeGenerator<'a> {
             TypeDefKind::Stream(s) => self.anonymous_type_stream(id, s, &ty.docs),
             TypeDefKind::Handle(handle) => self.anonymous_type_handle(id, handle, &ty.docs),
             TypeDefKind::Unknown => unreachable!(),
-            TypeDefKind::FixedSizeList(_, _) => todo!(),
+            TypeDefKind::FixedSizeList(t, size) => self.anonymous_type_fixed_size_list(id, t, *size, &ty.docs),
         }
     }
 }

crates/core/src/types.rs

@@ -204,7 +204,9 @@ impl Types {
                 info.has_own_handle = true;
             }
             TypeDefKind::Unknown => unreachable!(),
-            TypeDefKind::FixedSizeList(_, _) => todo!(),
+            TypeDefKind::FixedSizeList(ty, _) => {
+                info = self.type_info(resolve, ty);
+            }
         }
         let prev = self.type_info.insert(ty, info);
         assert!(prev.is_none());

crates/csharp/src/function.rs

@@ -1263,6 +1263,8 @@ impl Bindgen for FunctionBindgen<'_, '_> {
             | Instruction::StreamLift { .. }
             | Instruction::ErrorContextLower { .. }
             | Instruction::ErrorContextLift { .. } => todo!(),
+            Instruction::FixedSizeListLift { .. } => todo!(),
+            Instruction::FixedSizeListLower { .. } => todo!(),
         }
     }
 

crates/moonbit/src/lib.rs

@@ -2667,6 +2667,8 @@ impl Bindgen for FunctionBindgen<'_, '_> {
             | Instruction::StreamLift { .. }
             | Instruction::ErrorContextLower { .. }
             | Instruction::ErrorContextLift { .. } => todo!(),
+            Instruction::FixedSizeListLift { .. } => todo!(),
+            Instruction::FixedSizeListLower { .. } => todo!(),
         }
     }
 

crates/rust/src/bindgen.rs

@@ -1202,6 +1202,8 @@ impl Bindgen for FunctionBindgen<'_, '_> {
                     align = align.format(POINTER_SIZE_EXPRESSION)
                 ));
             }
+            Instruction::FixedSizeListLift { .. } => todo!(),
+            Instruction::FixedSizeListLower { .. } => todo!(),
         }
     }
 }

crates/rust/src/interface.rs

@@ -2932,4 +2932,8 @@ impl<'a, 'b> wit_bindgen_core::AnonymousTypeGenerator<'a> for AnonTypeGenerator<
         self.interface.print_optional_ty(ty.as_ref(), mode);
         self.interface.push_str(">");
     }
+    
+    fn anonymous_type_fixed_size_list(&mut self, _id: TypeId, _ty: &Type, _size: u32, _docs: &Docs) {
+        todo!()
+    }
 }

tests/runtime/fixed-size-list/runner.rs

@@ -0,0 +1,6 @@
+include!(env!("BINDINGS"));
+
+use test::lists::to_test::*;
+
+fn main() {
+}

tests/runtime/fixed-size-list/test.rs

@@ -0,0 +1,8 @@
+include!(env!("BINDINGS"));
+
+struct Component;
+
+export!(Component);
+
+impl exports::test::lists::to_test::Guest for Component {
+}