fix PR comments

Author: SebastienGllmt

crates/wave/src/core/decode.rs

@@ -33,8 +33,9 @@ use wasm_wave::wasm::{WasmType, WasmTypeKind, WasmValue as _};
 
 /// Read a wasm-wave `Value` from an async reader
 ///
-/// This mirrors `wrpc_runtime_wasmtime::codec::read_value` but without the
-/// `Index<R>` trait bound and `path` parameter, since wasm-wave doesn't support resources.
+/// This mirrors `wrpc_runtime_wasmtime::codec::read_value`
+/// but without the `Index<R>` trait bound and `path` parameter,
+/// since wasm-wave doesn't support resources, async or streams
 ///
 /// # Errors
 ///
@@ -158,7 +159,7 @@ where
             })?;
 
             let payload = if let Some(payload_type) = payload_type {
-                let value = Box::pin(read_value(r, &payload_type)).await?;
+                let value = Box::pin(read_value(r, payload_type)).await?;
                 Some(value)
             } else {
                 None
@@ -222,7 +223,7 @@ where
         }
         WasmTypeKind::Flags => {
             let names: Vec<_> = ty.flags_names().collect();
-            let byte_count = (names.len() + 7) / 8; // Ceiling division
+            let byte_count = names.len().div_ceil(8);
 
             let mut buf = vec![0u8; byte_count];
             r.read_exact(&mut buf).await?;

crates/wave/src/core/encode.rs

@@ -241,7 +241,7 @@ where
                         .flatten()
                         .context("variant case should have payload type")?;
                     let mut enc = self.with_type(&payload_type);
-                    enc.encode(&payload_val.into_owned(), dst)
+                    enc.encode(&*payload_val, dst)
                         .context("failed to encode variant payload")?;
                 }
                 Ok(())
@@ -293,7 +293,7 @@ where
                         .option_some_type()
                         .context("option type should have some type")?;
                     let mut enc = self.with_type(&inner_type);
-                    enc.encode(&inner.into_owned(), dst)
+                    enc.encode(&*inner, dst)
                         .context("failed to encode `option::some` value")?;
                     Ok(())
                 }
@@ -311,7 +311,7 @@ where
                                 dst.put_u8(0);
                                 if let Some(ok_ty) = ok_type {
                                     let mut enc = self.with_type(&ok_ty);
-                                    enc.encode(&val.into_owned(), dst)
+                                    enc.encode(&*val, dst)
                                         .context("failed to encode `result::ok` value")?;
                                 }
                             }
@@ -329,7 +329,7 @@ where
                                 dst.put_u8(1);
                                 if let Some(err_ty) = err_type {
                                     let mut enc = self.with_type(&err_ty);
-                                    enc.encode(&val.into_owned(), dst)
+                                    enc.encode(&*val, dst)
                                         .context("failed to encode `result::err` value")?;
                                 }
                             }

crates/wave/src/sync/decode.rs

@@ -12,7 +12,7 @@
 //!
 //! Note: `unpack` is not supported, as
 //! 1. `wasm-wave` doesn't't expose (`pub(super)`) its internal type system,
-//!     so it can't be used a generic passed to `unpack<T>`
+//!    so it can't be used a generic passed to `unpack<T>`
 //! 2. `unpack` only accepts one argument (`buf`)
 //!    but, because of (1), we need to be able to pass a `Type` to decode