properly delete providers on Delete Selected

Author: KatKatKateryna

pygeoapi_config_dialog.py

@@ -420,6 +420,12 @@ def edit_res_provider(self):
 
     def delete_res_provider(self):
         """Called from .ui file."""
+
+        # first, get selected item text and delete matching provider from Resource providers
+        self.data_from_ui_setter.delete_selected_provider_type_and_name(
+            self.listWidgetResProvider
+        )
+        # then, remove the item from the list widget
         self.ui_setter.delete_list_widget_selected_item(self.listWidgetResProvider)
 
     def filterResources(self, filter):

ui_widgets/DataSetterFromUi.py

@@ -314,6 +314,37 @@ def set_resource_data_from_ui(self):
         if res_name in config_data.resources:
             config_data.resources[new_alias] = config_data.resources.pop(res_name)
 
+    def delete_selected_provider_type_and_name(self, list_widget):
+        """Find and remove first matching resource provider with specified type and name."""
+        dialog: PygeoapiConfigDialog = self.dialog
+        config_data: ConfigData = dialog.config_data
+        res_name = dialog.current_res_name
+
+        # get selected provider data from a widget (by selection index)
+        providers_data_lists: list[list] = unpack_listwidget_values_to_sublists(
+            list_widget
+        )
+        selected_index = list_widget.currentRow()
+        if selected_index < 0:
+            return
+        selected_pr_data = providers_data_lists[selected_index]
+        selected_pr_type = get_enum_value_from_string(
+            ProviderTypes, selected_pr_data[0]
+        )
+        selected_pr_name = selected_pr_data[1]
+
+        # iterate through resource providers and delete the first matching one
+        for res_provider in config_data.resources[res_name].providers:
+            if isinstance(res_provider, dict):
+                continue  # ignore read-only providers
+
+            if (
+                res_provider.name == selected_pr_name
+                and res_provider.type == selected_pr_type
+            ):
+                config_data.resources[res_name].providers.remove(res_provider)
+                break
+
     def get_extents_crs_from_ui(self, dialog):
         return (
             "http://www.opengis.net/def/crs/"

ui_widgets/UiSetter.py

@@ -595,6 +595,6 @@ def add_listwidget_element_from_multi_widgets(
 
     def delete_list_widget_selected_item(self, list_widget):
         """Delete selected List item from widget."""
-        selected_item = list_widget.currentRow()
-        if selected_item >= 0:
-            list_widget.takeItem(selected_item)
+        selected_index = list_widget.currentRow()
+        if selected_index >= 0:
+            list_widget.takeItem(selected_index)