Skip to content

Commit 8feb4f0

Browse files
remove validation from host, port, admin
1 parent a742886 commit 8feb4f0

File tree

4 files changed

+25
-33
lines changed

4 files changed

+25
-33
lines changed

models/top_level/ServerConfig.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -22,17 +22,17 @@ class ServerOptionalBoolsEnum(Enum):
2222
@dataclass(kw_only=True)
2323
class ServerBindConfig:
2424
host: str = field(default="0.0.0.0")
25-
port: int = field(default=5000)
25+
port: int | str = field(default=5000)
2626

2727

2828
@dataclass(kw_only=True)
2929
class ServerLimitsConfig:
3030
default_items: int = field(default=10)
3131
max_items: int = field(default=10)
3232
on_exceed: ServerOnExceedEnum | None = None
33-
max_distance_x : int | None = None
34-
max_distance_y : int | None = None
35-
max_distance_units : int | None = None
33+
max_distance_x: int | None = None
34+
max_distance_y: int | None = None
35+
max_distance_units: int | None = None
3636

3737

3838
@dataclass(kw_only=True)
@@ -80,7 +80,7 @@ class ServerConfig:
8080
languages: list | None = None
8181
gzip: ServerOptionalBoolsEnum | None = None
8282
pretty_print: ServerOptionalBoolsEnum | None = None
83-
admin: ServerOptionalBoolsEnum | None = None
83+
admin: str | None = None
8484
cors: ServerOptionalBoolsEnum | None = None
8585
limits: ServerLimitsConfig | None = None
8686
templates: ServerTemplatesConfig | None = None

pygeoapi_config_dialog_base.ui

Lines changed: 13 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -58,9 +58,6 @@
5858
<layout class="QGridLayout" name="gridLayout">
5959
<item row="0" column="1">
6060
<widget class="QLineEdit" name="lineEditHost">
61-
<property name="inputMask">
62-
<string>000.0.0.0</string>
63-
</property>
6461
</widget>
6562
</item>
6663
<item row="0" column="0">
@@ -78,10 +75,7 @@
7875
</widget>
7976
</item>
8077
<item row="1" column="1">
81-
<widget class="QSpinBox" name="spinBoxPort">
82-
<property name="maximum">
83-
<number>9999</number>
84-
</property>
78+
<widget class="QLineEdit" name="lineEditPort">
8579
</widget>
8680
</item>
8781
</layout>
@@ -290,48 +284,51 @@
290284

291285
<item row="6" column="0" rowspan="1">
292286
<layout class="QVBoxLayout" name="horizontalLayout_7">
287+
288+
293289
<item>
294290
<layout class="QHBoxLayout" name="horizontalLayout_2">
295291
<item>
296292
<widget class="QLabel" name="label_4">
297293
<property name="text">
298-
<string>gzip</string>
294+
<string>admin</string>
299295
</property>
300296
</widget>
301297
</item>
302298
<item>
303-
<widget class="QComboBox" name="comboBoxGzip">
304-
</widget>
299+
<widget class="QLineEdit" name="lineEditAdmin"/>
305300
</item>
306301
</layout>
307302
</item>
308-
303+
304+
309305
<item>
310306
<layout class="QHBoxLayout" name="horizontalLayout_2">
311307
<item>
312308
<widget class="QLabel" name="label_4">
313309
<property name="text">
314-
<string>pretty print</string>
310+
<string>gzip</string>
315311
</property>
316312
</widget>
317313
</item>
318314
<item>
319-
<widget class="QComboBox" name="comboBoxPretty"/>
315+
<widget class="QComboBox" name="comboBoxGzip">
316+
</widget>
320317
</item>
321318
</layout>
322319
</item>
323-
320+
324321
<item>
325322
<layout class="QHBoxLayout" name="horizontalLayout_2">
326323
<item>
327324
<widget class="QLabel" name="label_4">
328325
<property name="text">
329-
<string>admin</string>
326+
<string>pretty print</string>
330327
</property>
331328
</widget>
332329
</item>
333330
<item>
334-
<widget class="QComboBox" name="comboBoxAdmin"/>
331+
<widget class="QComboBox" name="comboBoxPretty"/>
335332
</item>
336333
</layout>
337334
</item>

ui_widgets/DataSetterFromUi.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,10 @@ def set_data_from_ui(self):
5959

6060
# bind
6161
config_data.server.bind.host = dialog.lineEditHost.text()
62-
config_data.server.bind.port = dialog.spinBoxPort.value()
62+
try:
63+
config_data.server.bind.port = int(dialog.lineEditPort.text())
64+
except ValueError:
65+
config_data.server.bind.port = dialog.lineEditPort.text()
6366

6467
# gzip
6568
# config_data.server.gzip = dialog.checkBoxGzip.isChecked()
@@ -74,10 +77,7 @@ def set_data_from_ui(self):
7477
)
7578

7679
# admin
77-
# config_data.server.admin = dialog.checkBoxAdmin.isChecked()
78-
config_data.server.admin = get_enum_value_from_string(
79-
ServerOptionalBoolsEnum, dialog.comboBoxAdmin.currentText()
80-
)
80+
config_data.server.admin = dialog.lineEditAdmin.text()
8181

8282
# cors
8383
# config_data.server.cors = dialog.checkBoxCors.isChecked()

ui_widgets/UiSetter.py

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ def set_ui_from_data(self):
6868

6969
# bind
7070
self.dialog.lineEditHost.setText(config_data.server.bind.host)
71-
self.dialog.spinBoxPort.setValue(config_data.server.bind.port)
71+
self.dialog.lineEditPort.setText(str(config_data.server.bind.port))
7272

7373
# gzip
7474
# self.dialog.checkBoxGzip.setChecked(config_data.server.gzip)
@@ -85,11 +85,7 @@ def set_ui_from_data(self):
8585
)
8686

8787
# admin
88-
# self.dialog.checkBoxAdmin.setChecked(config_data.server.admin)
89-
set_combo_box_value_from_data(
90-
combo_box=self.dialog.comboBoxAdmin,
91-
value=str(config_data.server.admin),
92-
)
88+
self.dialog.lineEditAdmin.setText(config_data.server.admin)
9389

9490
# cors
9591
# self.dialog.checkBoxCors.setChecked(config_data.server.cors)
@@ -512,7 +508,6 @@ def customize_ui_on_launch(self):
512508
)
513509
fill_combo_box(dialog.comboBoxGzip, ServerOptionalBoolsEnum.NONE)
514510
fill_combo_box(dialog.comboBoxPretty, ServerOptionalBoolsEnum.NONE)
515-
fill_combo_box(dialog.comboBoxAdmin, ServerOptionalBoolsEnum.NONE)
516511
fill_combo_box(dialog.comboBoxCors, ServerOptionalBoolsEnum.NONE)
517512

518513
# add default values to the Resource UI

0 commit comments

Comments
 (0)