Skip to content

Added a more intuitive helper struct when printing ByteSize #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Added a more intuitive helper struct when printing ByteSize #32

wants to merge 2 commits into from

Conversation

@ChanTsune
Copy link
Contributor

@ChanTsune ChanTsune commented Aug 9, 2023

The Display trait currently implemented in ByteSize only supports decimal prefixes.
If we want to use a binary prefix, we need to use ByteSize::to_string_as.
I have added helper some struct and methods to use them to ByteSize to make these more intuitive with refer to std::path::Path.

use bytesize::ByteSize;

assert_eq!("100 B", format!("{}", ByteSize::b(100).binary_display()));
assert_eq!("1.8 TiB", format!("{}", ByteSize::tb(2).binary_display()));

assert_eq!("100 B", format!("{}", ByteSize::b(100).decimal_display()));
assert_eq!("2.0 TB", format!("{}", ByteSize::tb(2).decimal_display()));

If you like this PR, it would be my pleasure if you merge it!

@ChanTsune ChanTsune force-pushed the feature/display branch 2 times, most recently from dbcb3ad to 9530285 Compare September 6, 2023 01:25
@robjtede robjtede mentioned this pull request Feb 9, 2025
Closed
@ChanTsune
Copy link
Contributor Author

ChanTsune commented Feb 11, 2025

@robjtede I resolved conflict!

@robjtede
Copy link
Member

robjtede commented Feb 11, 2025

We'll chat about this approach once #69 is merged

@wookietreiber wookietreiber mentioned this pull request Feb 11, 2025
Merged
This was referenced Feb 12, 2025
Merged
Merged
@robjtede
Copy link
Member

robjtede commented Feb 13, 2025 •
edited
Loading

I took inspiration from this and the cookie crate to come up with #76. I think it's more extensible to use a single type with an inner format selection vs distinct types with display impls.

Thank you for your contibution to the project 🎉 this has been a much needed feature request imo.

@robjtede robjtede closed this Feb 13, 2025
@ChanTsune ChanTsune deleted the feature/display branch February 14, 2025 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@wookietreiber wookietreiber wookietreiber approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ChanTsune ChanTsune

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ChanTsune @robjtede @wookietreiber @hyunsik