Added async-test.

Test if this works on GHA

Author: rakshith-ravi

.github/workflows/pr.yml

@@ -56,12 +56,12 @@ jobs:
           command: build
           args: --release --all
 
-#      - name: Cargo test
-#        if: matrix.rust == 'stable'
-#        uses: actions-rs/cargo@v1
-#        with:
-#          command: test
-#          args: --release --all -- --test-threads=1
+      - name: Cargo test
+        if: matrix.rust == 'stable'
+        uses: actions-rs/cargo@v1
+        with:
+          command: test
+          args: --release --all -- --test-threads=1
 
       - name: Cargo fmt
         uses: actions-rs/cargo@v1

Cargo.toml

@@ -16,6 +16,9 @@ async-trait = "0.1.24"
 futures = "0.3.4"
 futures-util = "0.3.4"
 
+[dev-dependencies]
+async-std = { version = "1", features = ["attributes"] }
+
 [profile.release]
 lto = true
 panic = 'abort'

src/juno_module.rs

@@ -198,10 +198,7 @@ impl JunoModule {
 		if *self.registered.read().await || request_type == 1 {
 			self.connection.send(encoded).await;
 		} else {
-			self.message_buffer
-				.write()
-				.await
-				.append(&mut encoded);
+			self.message_buffer.write().await.append(&mut encoded);
 		}
 
 		let (sender, receiver) = channel::<Result<Value>>();
@@ -255,7 +252,14 @@ async fn on_data_listener(
 				Ok(Value::Null)
 			}
 			BaseMessage::TriggerHookResponse { .. } => {
-				execute_hook_triggered(message, &message_buffer, &write_sender, &registered_store, &hook_listeners).await
+				execute_hook_triggered(
+					message,
+					&message_buffer,
+					&write_sender,
+					&registered_store,
+					&hook_listeners,
+				)
+				.await
 			}
 			BaseMessage::Error { error, .. } => Err(Error::FromJuno(error)),
 			_ => Ok(Value::Null),

tests/connection/unix_socket_connection.rs

@@ -8,11 +8,7 @@ fn connection_object_should_create_successfully() {
 	let _socket_connection = UnixSocketConnection::new(String::from("socket_path"));
 }
 
-#[test]
-fn should_connect() -> Result<()> {
-	task::block_on(should_connect_async())
-}
-
+#[async_std::test]
 async fn should_connect_async() -> Result<()> {
 	// Setup to try and connect to socket server
 	let mut connection = UnixSocketConnection::new(String::from("./temp-1.sock"));
@@ -30,11 +26,7 @@ async fn should_connect_async() -> Result<()> {
 	Ok(())
 }
 
-#[test]
-fn should_connect_and_send_data() -> Result<()> {
-	task::block_on(should_connect_and_send_data_async())
-}
-
+#[async_std::test]
 async fn should_connect_and_send_data_async() -> Result<()> {
 	// Setup to try and connect to socket server
 	let mut connection = UnixSocketConnection::new(String::from("./temp-2.sock"));
@@ -62,11 +54,7 @@ async fn should_connect_and_send_data_async() -> Result<()> {
 	Ok(())
 }
 
-#[test]
-fn should_connect_and_read_data() -> Result<()> {
-	task::block_on(should_connect_and_read_data_async())
-}
-
+#[async_std::test]
 async fn should_connect_and_read_data_async() -> Result<()> {
 	// Setup to try and connect to socket server
 	let mut connection = UnixSocketConnection::new(String::from("./temp-3.sock"));
@@ -96,11 +84,7 @@ async fn should_connect_and_read_data_async() -> Result<()> {
 	Ok(())
 }
 
-#[test]
-fn should_connect_and_send_data_from_cloned_sender() -> Result<()> {
-	task::block_on(should_connect_and_send_data_from_cloned_sender_async())
-}
-
+#[async_std::test]
 async fn should_connect_and_send_data_from_cloned_sender_async() -> Result<()> {
 	// Setup to try and connect to socket server
 	let mut connection = UnixSocketConnection::new(String::from("./temp-4.sock"));
@@ -159,31 +143,18 @@ fn should_clone_write_sender_without_setup_and_panic() {
 	connection.clone_write_sender();
 }
 
-/*
-#[test]
+#[async_std::test]
 #[should_panic]
-fn should_setup_connection_twice_and_panic() {
-	let handle = std::thread::spawn(|| {
-		task::block_on(should_setup_connection_twice_and_panic_async()).unwrap();
-	})
-	.join();
-	task::block_on(remove_file("./temp-5.sock")).unwrap();
-	handle.unwrap();
-}
-
-async fn should_setup_connection_twice_and_panic_async() -> Result<()> {
+async fn should_setup_connection_twice_and_panic_async() {
 	// Setup to try and connect to socket server
 	let mut connection = UnixSocketConnection::new(String::from("./temp-5.sock"));
 
 	// Listen for unix socket connections
-	let socket = UnixListener::bind("./temp-5.sock").await?;
+	let socket = UnixListener::bind("./temp-5.sock").await.unwrap();
 	let mut incoming = socket.incoming();
 	let (_stream, result) = future::join(incoming.next(), connection.setup_connection()).await;
 	result.unwrap();
 	let (_, result) = future::join(incoming.next(), connection.setup_connection()).await;
 	result.unwrap();
 	drop(socket);
-
-	Ok(())
 }
-*/