Skip to content

Commit 09ca0f8

Browse files
committed
Back off desync_mitigation_mode to defensive
Setting desync_mitigation_mode to strictest breaks clients that aren't strictly RFC 7230 compliant (notably, AWS API Gateway). Setting this attribute to defensive provides sufficent protection against desync attacks, while still allowing requests from clients that we can't perfect. https://en.wikipedia.org/wiki/Robustness_principle
1 parent 4feea83 commit 09ca0f8

File tree

4 files changed

+5
-5
lines changed

4 files changed

+5
-5
lines changed

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ Also Note: CodePipeline and CodeDeploy cannot be used together to deploy a Lambd
2727
For a Zip file lambda
2828
```hcl
2929
module "lambda_api" {
30-
source = "github.com/byu-oit/terraform-aws-lambda-api?ref=v3.0.0"
30+
source = "github.com/byu-oit/terraform-aws-lambda-api?ref=v3.0.1"
3131
app_name = "my-lambda-codedeploy-dev"
3232
zip_filename = "./src/lambda.zip"
3333
zip_handler = "index.handler"
@@ -50,7 +50,7 @@ module "lambda_api" {
5050
For a docker image lambda:
5151
```hcl
5252
module "lambda_api" {
53-
source = "github.com/byu-oit/terraform-aws-lambda-api?ref=v3.0.0"
53+
source = "github.com/byu-oit/terraform-aws-lambda-api?ref=v3.0.1"
5454
app_name = "my-docker-lambda"
5555
image_uri = "my-image-from-my-ecr:latest"
5656
hosted_zone = module.acs.route53_zone

examples/docker-lambda/docker.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ module "acs" {
99

1010
module "lambda_api" {
1111
# source = "../../"
12-
source = "github.com/byu-oit/terraform-aws-lambda-api?ref=v3.0.0"
12+
source = "github.com/byu-oit/terraform-aws-lambda-api?ref=v3.0.1"
1313
app_name = "my-docker-lambda"
1414
image_uri = "my-image-from-my-ecr:latest"
1515
hosted_zone = module.acs.route53_zone

examples/simple-lambda-in-vpc/example.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ module "acs" {
99

1010
module "lambda_api" {
1111
# source = "../../"
12-
source = "github.com/byu-oit/terraform-aws-lambda-api?ref=v3.0.0"
12+
source = "github.com/byu-oit/terraform-aws-lambda-api?ref=v3.0.1"
1313
app_name = "my-lambda-dev"
1414
zip_filename = "./src/lambda.zip"
1515
zip_handler = "index.handler"

main.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ locals {
3030

3131
resource "aws_alb" "alb" {
3232
name = local.alb_name
33-
desync_mitigation_mode = "strictest"
33+
desync_mitigation_mode = "defensive"
3434
subnets = var.public_subnet_ids
3535
security_groups = [aws_security_group.alb-sg.id]
3636
tags = var.tags

0 commit comments

Comments
 (0)