Skip to content

Commit 8494ccf

Browse files
authored
Merge pull request #39 from byu-oit/desync_mitigation_mode
Set `desync_mitigation_mode` to `strictest` in ALB
2 parents 50acfa7 + 1be73ac commit 8494ccf

File tree

10 files changed

+22
-17
lines changed

10 files changed

+22
-17
lines changed

README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ Also Note: CodePipeline and CodeDeploy cannot be used together to deploy a Lambd
2727
For a Zip file lambda
2828
```hcl
2929
module "lambda_api" {
30-
source = "github.com/byu-oit/terraform-aws-lambda-api?ref=v2.2.0"
30+
source = "github.com/byu-oit/terraform-aws-lambda-api?ref=v3.0.0"
3131
app_name = "my-lambda-codedeploy-dev"
3232
zip_filename = "./src/lambda.zip"
3333
zip_handler = "index.handler"
@@ -50,7 +50,7 @@ module "lambda_api" {
5050
For a docker image lambda:
5151
```hcl
5252
module "lambda_api" {
53-
source = "github.com/byu-oit/terraform-aws-lambda-api?ref=v2.2.0"
53+
source = "github.com/byu-oit/terraform-aws-lambda-api?ref=v3.0.0"
5454
app_name = "my-docker-lambda"
5555
image_uri = "my-image-from-my-ecr:latest"
5656
hosted_zone = module.acs.route53_zone
@@ -86,7 +86,7 @@ module "lambda_api" {
8686

8787
## Requirements
8888
* Terraform version 0.13.2 or greater
89-
* AWS provider version 3.0 or greater
89+
* AWS provider version 3.67 or greater
9090

9191
## Inputs
9292
| Name | Type | Description | Default |

changelog.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
# Changelog
22

3+
## v3.0.0
4+
2/6/2023 - Set `desync_mitigation_mode` to `strictest` in ALB
5+
- Require AWS provider >=3.67 to support `desync_mitigation_mode`
6+
37
## v2.2.0
48
11/18/2022 - support ARM 64 architecture
59
- allow pass through of architecture to support arm64. Default is x86_64.

examples/ci-0_13/ci.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ terraform {
33
}
44

55
provider "aws" {
6-
version = "~> 3.0"
6+
version = "~> 3.67"
77
region = "us-west-2"
88
}
99

examples/ci-0_14/ci.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ terraform {
33
}
44

55
provider "aws" {
6-
version = "~> 3.0"
6+
version = "~> 3.67"
77
region = "us-west-2"
88
}
99

examples/ci-1/ci.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ terraform {
33
required_providers {
44
aws = {
55
source = "hashicorp/aws"
6-
version = "~> 3.73.0"
6+
version = "~> 3.67"
77
}
88
}
99
}

examples/docker-lambda/docker.tf

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
provider "aws" {
2-
version = "~> 3.0"
2+
version = "~> 3.67"
33
region = "us-west-2"
44
}
55

@@ -9,7 +9,7 @@ module "acs" {
99

1010
module "lambda_api" {
1111
# source = "../../"
12-
source = "github.com/byu-oit/terraform-aws-lambda-api?ref=v2.2.0"
12+
source = "github.com/byu-oit/terraform-aws-lambda-api?ref=v3.0.0"
1313
app_name = "my-docker-lambda"
1414
image_uri = "my-image-from-my-ecr:latest"
1515
hosted_zone = module.acs.route53_zone

examples/no-codedeploy/example.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
provider "aws" {
2-
version = "~> 3.0"
2+
version = "~> 3.67"
33
region = "us-west-2"
44
}
55

examples/simple-lambda-in-vpc/example.tf

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
provider "aws" {
2-
version = "~> 3.0"
2+
version = "~> 3.67"
33
region = "us-west-2"
44
}
55

@@ -9,7 +9,7 @@ module "acs" {
99

1010
module "lambda_api" {
1111
# source = "../../"
12-
source = "github.com/byu-oit/terraform-aws-lambda-api?ref=v2.2.0"
12+
source = "github.com/byu-oit/terraform-aws-lambda-api?ref=v3.0.0"
1313
app_name = "my-lambda-dev"
1414
zip_filename = "./src/lambda.zip"
1515
zip_handler = "index.handler"

examples/simple-lambda-with-deploy-test/example.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
provider "aws" {
2-
version = "~> 3.0"
2+
version = "~> 3.67"
33
region = "us-west-2"
44
}
55

main.tf

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
terraform {
22
required_version = ">= 0.13.2"
33
required_providers {
4-
aws = ">= 3.0"
4+
aws = ">= 3.67"
55
}
66
}
77

@@ -29,10 +29,11 @@ locals {
2929
# ==================== ALB ====================
3030

3131
resource "aws_alb" "alb" {
32-
name = local.alb_name
33-
subnets = var.public_subnet_ids
34-
security_groups = [aws_security_group.alb-sg.id]
35-
tags = var.tags
32+
name = local.alb_name
33+
desync_mitigation_mode = "strictest"
34+
subnets = var.public_subnet_ids
35+
security_groups = [aws_security_group.alb-sg.id]
36+
tags = var.tags
3637
}
3738

3839
resource "aws_security_group" "alb-sg" {

0 commit comments

Comments
 (0)