Skip to content

Commit dbf98f4

Browse files
committed
fix: app_name max length to 28
1 parent f832452 commit dbf98f4

File tree

9 files changed

+33
-15
lines changed

9 files changed

+33
-15
lines changed

.github/dependabot.yml

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
version: 2
2+
3+
updates:
4+
- package-ecosystem: github-actions
5+
directory: '/' # Check files in .github/workflows
6+
schedule:
7+
interval: monthly
8+
target-branch: main
9+
10+
- package-ecosystem: terraform
11+
directory: '/'
12+
schedule:
13+
interval: monthly
14+
target-branch: main

.github/workflows/ci.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,15 +2,15 @@ name: CI
22

33
on:
44
pull_request:
5-
branches: [master]
5+
branches: [main]
66

77
jobs:
88
env:
99
name: Set Env Vars
1010
runs-on: ubuntu-latest
1111
steps:
12-
- name: Set up DEV Environment Variables
13-
if: github.base_ref == 'master'
12+
- name: Set up Environment Variables
13+
if: github.base_ref == 'main'
1414
run: |
1515
matrix='{
1616
"env":[
@@ -62,7 +62,7 @@ jobs:
6262
matrix: ${{ fromJson(needs.env.outputs.matrix) }}
6363
fail-fast: false
6464
steps:
65-
- uses: actions/checkout@v2
65+
- uses: actions/checkout@v3
6666

6767
- name: Configure AWS credentials
6868
uses: aws-actions/configure-aws-credentials@v1

README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ Also Note: CodePipeline and CodeDeploy cannot be used together to deploy a Lambd
2727
For a Zip file lambda
2828
```hcl
2929
module "lambda_api" {
30-
source = "github.com/byu-oit/terraform-aws-lambda-api?ref=v2.0.0"
30+
source = "github.com/byu-oit/terraform-aws-lambda-api?ref=v2.0.1"
3131
app_name = "my-lambda-codedeploy-dev"
3232
env = "dev"
3333
zip_filename = "./src/lambda.zip"
@@ -51,7 +51,7 @@ module "lambda_api" {
5151
For a docker image lambda:
5252
```hcl
5353
module "lambda_api" {
54-
source = "github.com/byu-oit/terraform-aws-lambda-api?ref=v2.0.0"
54+
source = "github.com/byu-oit/terraform-aws-lambda-api?ref=v2.0.1"
5555
app_name = "my-docker-lambda"
5656
image_uri = "my-image-from-my-ecr:latest"
5757
hosted_zone = module.acs.route53_zone
@@ -92,7 +92,7 @@ module "lambda_api" {
9292
## Inputs
9393
| Name | Type | Description | Default |
9494
| --- | --- | --- | --- |
95-
| app_name | string | Application name to name your Lambda API and other resources (Must be <= 24 alphanumeric characters) | |
95+
| app_name | string | Application name to name your Lambda API and other resources (Must be <= 28 alphanumeric characters) | |
9696
| image_uri | string | ECR Image URI containing the function's deployment package (conflicts with `zip_file`)| null |
9797
| zip_filename | string | File that contains your compiled or zipped source code. |
9898
| zip_handler | string | Lambda event handler |
@@ -231,4 +231,4 @@ If manual rollback is needed after the deployment has completed, that can be don
231231

232232
If you require additional variables please create an [issue](https://github.com/byu-oit/terraform-aws-lambda-api/issues)
233233
and/or a [pull request](https://github.com/byu-oit/terraform-aws-lambda-api/pulls) to add the variable and reach
234-
out to the Terraform Working Group on slack (`#terraform` channel).
234+
out to the Application Engineering SpecOps Green team (`IT Collaboration` -> `OIT ENG AppEng - SpecOps Green` channel).

changelog.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,3 +10,7 @@
1010
- removed `use_codedeploy` variable - just include the codedeploy variables to enable codedeploy
1111
- removed `env` variable - just include the env inside the `app_name` variable
1212
- added `domain_url` variable to enable a custom API URL
13+
14+
## v2.0.1
15+
3/11/2022 - increased `app_name` variable length
16+
- increased `app_name` variable length from 24 to 28

examples/docker-lambda/docker.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ module "acs" {
99

1010
module "lambda_api" {
1111
# source = "../../"
12-
source = "github.com/byu-oit/terraform-aws-lambda-api?ref=v2.0.0"
12+
source = "github.com/byu-oit/terraform-aws-lambda-api?ref=v2.0.1"
1313
app_name = "my-docker-lambda"
1414
image_uri = "my-image-from-my-ecr:latest"
1515
hosted_zone = module.acs.route53_zone

examples/no-codedeploy/example.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ module "acs" {
99

1010
module "lambda_api" {
1111
# source = "../../"
12-
source = "github.com/byu-oit/terraform-aws-lambda-api?ref=v2.0.0"
12+
source = "github.com/byu-oit/terraform-aws-lambda-api?ref=v2.0.1"
1313
app_name = "my-lambda-dev"
1414
zip_filename = "./src/lambda.zip"
1515
zip_handler = "index.handler"

examples/simple-lambda-in-vpc/example.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ module "acs" {
99

1010
module "lambda_api" {
1111
# source = "../../"
12-
source = "github.com/byu-oit/terraform-aws-lambda-api?ref=v2.0.0"
12+
source = "github.com/byu-oit/terraform-aws-lambda-api?ref=v2.0.1"
1313
app_name = "my-lambda-dev"
1414
zip_filename = "./src/lambda.zip"
1515
zip_handler = "index.handler"

examples/simple-lambda-with-deploy-test/example.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ module "acs" {
99

1010
module "lambda_api" {
1111
# source = "../../"
12-
source = "github.com/byu-oit/terraform-aws-lambda-api?ref=v2.0.0"
12+
source = "github.com/byu-oit/terraform-aws-lambda-api?ref=v2.0.1"
1313
app_name = "my-lambda-codedeploy-dev"
1414
env = "dev"
1515
zip_filename = "./src/lambda.zip"

variables.tf

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
variable "app_name" {
22
type = string
3-
description = "Application name to name your Fargate API and other resources. Must be <= 24 characters."
3+
description = "Application name to name your Fargate API and other resources. Must be <= 28 characters."
44
validation {
5-
condition = length(var.app_name) <= 24
6-
error_message = "Must be <= 24 characters."
5+
condition = length(var.app_name) <= 28
6+
error_message = "Must be <= 28 characters."
77
}
88
}
99

0 commit comments

Comments
 (0)