fix: added <=24 character info for app_name variable

Author: yoshutch

.github/workflows/ci.yml

@@ -42,7 +42,6 @@ jobs:
   format:
     name: Terraform Format
     runs-on: ubuntu-latest
-    needs: env
     steps:
       - uses: actions/checkout@v2
 

README.md

@@ -92,7 +92,7 @@ module "lambda_api" {
 ## Inputs
 | Name | Type  | Description | Default |
 | --- | --- | --- | --- |
-| app_name | string | application name (include the env aka. 'my-api-dev') | |
+| app_name | string | Application name to name your Lambda API and other resources (Must be <= 24 alphanumeric characters) | |
 | image_uri | string | ECR Image URI containing the function's deployment package (conflicts with `zip_file`)| null |
 | zip_filename | string | File that contains your compiled or zipped source code. |
 | zip_handler | string | Lambda event handler |

variables.tf

@@ -1,6 +1,10 @@
 variable "app_name" {
   type        = string
-  description = "application name (include the env in the name)"
+  description = "Application name to name your Fargate API and other resources. Must be <= 24 characters."
+  validation {
+    condition     = length(var.app_name) <= 24
+    error_message = "Must be <= 24 characters."
+  }
 }
 
 variable "image_uri" {
@@ -61,12 +65,6 @@ variable "https_certificate_arn" {
   description = "ARN of the HTTPS certificate of the hosted zone/domain."
 }
 
-#variable "use_codedeploy" {
-#  type        = bool
-#  description = "If true, CodeDeploy App and Deployment Group will be created and TF will not update alias to point to new versions of the Lambda (because CodeDeploy will do that)."
-#  default     = false
-#}
-
 variable "codedeploy_service_role_arn" {
   type        = string
   description = "ARN of the IAM Role for the CodeDeploy to use to initiate new deployments. (usually the PowerBuilder Role)"