Skip to content

Commit 5d57493

Browse files
vincentfretinvincentfretin
authored
Use defer instead of type="module" to load umd builds (fix #72) (#73)
1 parent 654476e commit 5d57493

File tree

3 files changed

+27
-27
lines changed

3 files changed

+27
-27
lines changed

‎README.md‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ This is an alternate implementation of how Hubs imported the scene glb with afra
1010
## Usage
1111

1212
Some features require [patches in three.js](https://github.com/c-frame/aframe-gltf-model-plus/blob/main/docs/custom_aframe_build.md) to work properly. We're using the aframe ES module with a super-three fork with some HUBS patches in the code below.
13-
Be sure to load any script that uses global AFRAME or THREE with `type="module"`.
13+
Be sure to load any script that uses global AFRAME or THREE with `defer`.
1414

1515
```html
1616
<head>
@@ -27,7 +27,7 @@ Be sure to load any script that uses global AFRAME or THREE with `type="module"`
2727
<script type="module">
2828
import AFRAME from 'aframe';
2929
</script>
30-
<script src="https://cdn.jsdelivr.net/gh/c-frame/aframe-gltf-model-plus@1.2.0/dist/gltf-model-plus.min.js" type="module"></script>
30+
<script defer src="https://cdn.jsdelivr.net/gh/c-frame/aframe-gltf-model-plus@1.2.0/dist/gltf-model-plus.min.js"></script>
3131
<script>
3232
window.absoluteURLForAsset = (url) => {
3333
if (!url) return "";
@@ -98,13 +98,13 @@ and refresh the page.
9898
You can deploy the content of the `examples/playground` folder to any server with static hosting but be sure to replace those two script tags:
9999

100100
```html
101-
<script src="../../dist/gltf-model-plus.min.js" type="module"></script>
101+
<script defer src="../../dist/gltf-model-plus.min.js"></script>
102102
```
103103

104104
by
105105

106106
```html
107-
<script src="https://cdn.jsdelivr.net/gh/c-frame/aframe-gltf-model-plus@1.2.0/dist/gltf-model-plus.min.js" type="module"></script>
107+
<script defer src="https://cdn.jsdelivr.net/gh/c-frame/aframe-gltf-model-plus@1.2.0/dist/gltf-model-plus.min.js"></script>
108108
```
109109

110110
Depending on your needs, if your experience doesn't require multi-users, you can run it on GitHub Pages for free. For this you need to push the folder content on a public GitHub repository and enable GitHub Pages in the repository settings.

‎examples/outdoor-festival/index.html‎

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -16,15 +16,15 @@
1616
<script type="module">
1717
import AFRAME from 'aframe';
1818
</script>
19-
<script src="https://cdn.jsdelivr.net/gh/c-frame/aframe-extras@7.5.4/dist/aframe-extras.min.js" type="module"></script>
20-
<script src="https://cdnjs.cloudflare.com/ajax/libs/socket.io/4.8.1/socket.io.min.js"></script>
21-
<script src="https://cdn.jsdelivr.net/npm/open-easyrtc@2.1.0/api/easyrtc.js"></script>
22-
<script src="https://cdn.jsdelivr.net/npm/networked-aframe@^0.14.0/dist/networked-aframe.min.js" type="module"></script>
23-
<script src="https://cdn.jsdelivr.net/gh/networked-aframe/naf-janus-adapter@3.2.0/examples/js/audio-system.js" type="module"></script>
24-
<script src="https://cdn.jsdelivr.net/npm/@fern-solutions/aframe-mirror@1.1.1/dist/mirror.umd.min.js" type="module"></script>
25-
<script src="https://cdn.jsdelivr.net/gh/c-frame/aframe-cursor-teleport@1.6.0/dist/aframe-cursor-teleport-component.min.js" type="module"></script>
26-
<script src="https://cdn.jsdelivr.net/gh/AdaRoseCannon/aframe-xr-boilerplate@bca4792/simple-navmesh-constraint.js" type="module"></script>
27-
<script src="https://cdn.jsdelivr.net/npm/aframe-troika-text@0.12.0/dist/aframe-troika-text.min.js" type="module"></script>
19+
<script defer src="https://cdn.jsdelivr.net/gh/c-frame/aframe-extras@7.5.4/dist/aframe-extras.min.js"></script>
20+
<script defer src="https://cdnjs.cloudflare.com/ajax/libs/socket.io/4.8.1/socket.io.min.js"></script>
21+
<script defer src="https://cdn.jsdelivr.net/npm/open-easyrtc@2.1.0/api/easyrtc.js"></script>
22+
<script defer src="https://cdn.jsdelivr.net/npm/networked-aframe@^0.14.0/dist/networked-aframe.min.js"></script>
23+
<script defer src="https://cdn.jsdelivr.net/gh/networked-aframe/naf-janus-adapter@3.2.0/examples/js/audio-system.js"></script>
24+
<script defer src="https://cdn.jsdelivr.net/npm/@fern-solutions/aframe-mirror@1.1.1/dist/mirror.umd.min.js"></script>
25+
<script defer src="https://cdn.jsdelivr.net/gh/c-frame/aframe-cursor-teleport@1.6.0/dist/aframe-cursor-teleport-component.min.js"></script>
26+
<script defer src="https://cdn.jsdelivr.net/gh/AdaRoseCannon/aframe-xr-boilerplate@bca4792/simple-navmesh-constraint.js"></script>
27+
<script defer src="https://cdn.jsdelivr.net/npm/aframe-troika-text@0.12.0/dist/aframe-troika-text.min.js"></script>
2828
<script>
2929
// @var url {string} The url as string.
3030
window.absoluteURLForAsset = (url) => {
@@ -39,7 +39,7 @@
3939
return url;
4040
};
4141
</script>
42-
<script src="../../dist/gltf-model-plus.min.js" type="module"></script>
42+
<script defer src="../../dist/gltf-model-plus.min.js"></script>
4343
<script type="module">
4444
// Replace this by your own player-info component
4545
AFRAME.registerComponent("player-info", {

‎examples/playground/index.html‎

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -16,17 +16,17 @@
1616
<script type="module">
1717
import AFRAME from 'aframe';
1818
</script>
19-
<script src="https://cdn.jsdelivr.net/gh/c-frame/aframe-extras@7.5.4/dist/aframe-extras.min.js" type="module"></script>
20-
<script src="https://cdnjs.cloudflare.com/ajax/libs/socket.io/4.8.1/socket.io.min.js"></script>
21-
<script src="https://cdn.jsdelivr.net/npm/open-easyrtc@2.1.0/api/easyrtc.js"></script>
22-
<script src="https://cdn.jsdelivr.net/npm/networked-aframe@^0.14.0/dist/networked-aframe.min.js" type="module"></script>
23-
<script src="https://cdn.jsdelivr.net/gh/networked-aframe/naf-janus-adapter@3.2.0/examples/js/audio-system.js" type="module"></script>
24-
<script src="https://cdn.jsdelivr.net/npm/@fern-solutions/aframe-mirror@1.1.1/dist/mirror.umd.min.js" type="module"></script>
25-
<script src="https://cdn.jsdelivr.net/gh/c-frame/aframe-cursor-teleport@1.6.0/dist/aframe-cursor-teleport-component.min.js" type="module"></script>
26-
<script src="https://cdn.jsdelivr.net/gh/AdaRoseCannon/aframe-xr-boilerplate@bca4792/simple-navmesh-constraint.js" type="module"></script>
27-
<script src="https://cdn.jsdelivr.net/npm/aframe-troika-text@0.12.0/dist/aframe-troika-text.min.js" type="module"></script>
28-
<script src="https://cdn.jsdelivr.net/npm/aframe-look-at-component@1.0.0/dist/aframe-look-at-component.min.js" type="module"></script>
29-
<script src="https://cdn.jsdelivr.net/gh/networked-aframe/naf-valid-avatars@4b116a4/src/player-info.js" type="module"></script>
19+
<script defer src="https://cdn.jsdelivr.net/gh/c-frame/aframe-extras@7.5.4/dist/aframe-extras.min.js"></script>
20+
<script defer src="https://cdnjs.cloudflare.com/ajax/libs/socket.io/4.8.1/socket.io.min.js"></script>
21+
<script defer src="https://cdn.jsdelivr.net/npm/open-easyrtc@2.1.0/api/easyrtc.js"></script>
22+
<script defer src="https://cdn.jsdelivr.net/npm/networked-aframe@^0.14.0/dist/networked-aframe.min.js"></script>
23+
<script defer src="https://cdn.jsdelivr.net/gh/networked-aframe/naf-janus-adapter@3.2.0/examples/js/audio-system.js"></script>
24+
<script defer src="https://cdn.jsdelivr.net/npm/@fern-solutions/aframe-mirror@1.1.1/dist/mirror.umd.min.js"></script>
25+
<script defer src="https://cdn.jsdelivr.net/gh/c-frame/aframe-cursor-teleport@1.6.0/dist/aframe-cursor-teleport-component.min.js"></script>
26+
<script defer src="https://cdn.jsdelivr.net/gh/AdaRoseCannon/aframe-xr-boilerplate@bca4792/simple-navmesh-constraint.js"></script>
27+
<script defer src="https://cdn.jsdelivr.net/npm/aframe-troika-text@0.12.0/dist/aframe-troika-text.min.js"></script>
28+
<script defer src="https://cdn.jsdelivr.net/npm/aframe-look-at-component@1.0.0/dist/aframe-look-at-component.min.js"></script>
29+
<script defer src="https://cdn.jsdelivr.net/gh/networked-aframe/naf-valid-avatars@4b116a4/src/player-info.js"></script>
3030
<script>
3131
// @var url {string} The url as string.
3232
window.absoluteURLForAsset = (url) => {
@@ -42,7 +42,7 @@
4242
return url;
4343
};
4444
</script>
45-
<script src="../../dist/gltf-model-plus.min.js" type="module"></script>
45+
<script defer src="../../dist/gltf-model-plus.min.js"></script>
4646
<script type="module">
4747
AFRAME.registerComponent("shortcuts", {
4848
init() {
@@ -232,7 +232,7 @@ <h2 style="margin: 0; font-size: 1.2rem">Help</h2>
232232
See https://github.com/networked-aframe/naf-nametag-solidjs/blob/main/public/ui-components.html
233233
for more details on how to use the web components.
234234
-->
235-
<script src="https://cdn.jsdelivr.net/gh/networked-aframe/naf-nametag-solidjs@49ccc23/public/dist/ui-components.js" type="module"></script>
235+
<script defer src="https://cdn.jsdelivr.net/gh/networked-aframe/naf-nametag-solidjs@49ccc23/public/dist/ui-components.js"></script>
236236

237237
<div class="naf-top-bar-right">
238238
<button

0 commit comments

Comments
 (0)