refactor: move row_heights into Data

Author: c-git

src/app.rs

@@ -142,16 +142,9 @@ impl LogViewerApp {
 
         if let Some(data) = &mut self.data {
             table.body(|body| {
-                // TODO 4: Figure out if calculating these values only once is worth it.
-                // TODO 4: Remove hard coded "msg"
-                let heights: Vec<f32> = data
-                    .rows_iter()
-                    .map(|x| {
-                        (1f32).max(x.field_value("msg").display().lines().count() as f32)
-                            * text_height
-                    })
-                    .collect();
-                body.heterogeneous_rows(heights.into_iter(), |mut row| {
+                let heights = data.row_heights(text_height);
+
+                body.heterogeneous_rows(heights, |mut row| {
                     let row_index = row.index();
                     let log_row = &data
                         .rows_iter()

src/app/data.rs

@@ -311,6 +311,16 @@ impl Data {
                 "No"
             })
     }
+
+    pub(crate) fn row_heights(&self, text_height: f32) -> impl Iterator<Item = f32> {
+        self.rows_iter()
+            .map(|x| {
+                // TODO 4: Remove hard coded "msg"
+                (1f32).max(x.field_value("msg").display().lines().count() as f32) * text_height
+            })
+            .collect::<Vec<f32>>()
+            .into_iter()
+    }
 }
 
 /// If the slice of fields and values matches the filter then the indices of the fields that match are returned or None if it does not match