[localcontroller] Triggers a request timeout when a request cannot be forward to the Central System or to the Charge Point

Author: c-jimenez

src/localcontroller/centralsystem/CentralSystemHandler.h

@@ -415,7 +415,6 @@ class CentralSystemHandler
                 if (cs_error.empty())
                 {
                     LOG_WARNING << "[" << m_identifier << "] - Unable to forward [" << action << "] request";
-                    error = ocpp::rpc::IRpc::RPC_ERROR_INTERNAL;
                 }
                 else
                 {
@@ -428,7 +427,6 @@ class CentralSystemHandler
         else
         {
             LOG_WARNING << "[" << m_identifier << "] - Unable to forward [" << action << "] request";
-            error = ocpp::rpc::IRpc::RPC_ERROR_INTERNAL;
         }
 
         return ret;

src/localcontroller/centralsystem/CentralSystemProxy.cpp

@@ -563,7 +563,7 @@ void CentralSystemProxy::rcpMessageReceived(const std::string& msg)
 /** @copydoc void IRpc::ISpy::rcpMessageSent(const std::string& msg) */
 void CentralSystemProxy::rcpMessageSent(const std::string& msg)
 {
-    LOG_COM << "[" << m_identifier << "] - RX : " << msg;
+    LOG_COM << "[" << m_identifier << "] - TX : " << msg;
 }
 
 // RpcClient::IListener interface

src/localcontroller/chargepoint/ChargePointHandler.h

@@ -266,7 +266,6 @@ class ChargePointHandler
             if (cs_error.empty())
             {
                 LOG_WARNING << "[" << m_identifier << "] - Unable to forward [" << action << "] request";
-                error = ocpp::rpc::IRpc::RPC_ERROR_INTERNAL;
             }
             else
             {

src/rpc/RpcBase.cpp

@@ -415,11 +415,10 @@ void RpcBase::rxThread()
         else
         {
             // Error
-            if (error_code.empty())
+            if (!error_code.empty())
             {
-                error_code = RPC_ERROR_GENERIC;
+                sendCallError(rpc_message->unique_id, error_code.c_str(), error);
             }
-            sendCallError(rpc_message->unique_id, error_code.c_str(), error);
         }
 
         // Free resources