Skip to content

Commit cca928a

Browse files
committed
[websocket] Align listener namings between client and server implementations
1 parent b0619ca commit cca928a

File tree

6 files changed

+19
-27
lines changed

6 files changed

+19
-27
lines changed

src/rpc/RpcClient.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ namespace rpc
3434
{
3535

3636
/** @brief RPC client implementation */
37-
class RpcClient : public IRpcClient, public ocpp::websockets::IWebsocketClient::IWebsocketClientListener
37+
class RpcClient : public IRpcClient, public ocpp::websockets::IWebsocketClient::IListener
3838
{
3939
public:
4040
/** @brief Constructor */

src/websockets/IWebsocketClient.h

Lines changed: 8 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ class IWebsocketClient
3232
{
3333
public:
3434
// Forward declarations
35-
class IWebsocketClientListener;
35+
class IListener;
3636
struct Credentials;
3737

3838
/** @brief Destructor */
@@ -79,33 +79,25 @@ class IWebsocketClient
7979
* @brief Register a listener to the websocket events
8080
* @param listener Listener object
8181
*/
82-
virtual void registerListener(IWebsocketClientListener& listener) = 0;
82+
virtual void registerListener(IListener& listener) = 0;
8383

8484
/** @brief Interface for the websocket clients listeners */
85-
class IWebsocketClientListener
85+
class IListener
8686
{
8787
public:
8888
/** @brief Destructor */
89-
virtual ~IWebsocketClientListener() { }
89+
virtual ~IListener() { }
9090

91-
/**
92-
* @brief Called when connection is successfull
93-
*/
91+
/** @brief Called when connection is successfull */
9492
virtual void wsClientConnected() = 0;
9593

96-
/**
97-
* @brief Called when connection failed
98-
*/
94+
/** @brief Called when connection failed */
9995
virtual void wsClientFailed() = 0;
10096

101-
/**
102-
* @brief Called when connection is lost
103-
*/
97+
/** @brief Called when connection is lost */
10498
virtual void wsClientDisconnected() = 0;
10599

106-
/**
107-
* @brief Called when a critical error occured
108-
*/
100+
/** @brief Called when a critical error occured */
109101
virtual void wsClientError() = 0;
110102

111103
/**

src/websockets/libwebsockets/LibWebsocketClient.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -184,8 +184,8 @@ bool LibWebsocketClient::send(const void* data, size_t size)
184184
return ret;
185185
}
186186

187-
/** @copydoc void IWebsocketClient::registerListener(IWebsocketClientListener&) */
188-
void LibWebsocketClient::registerListener(IWebsocketClientListener& listener)
187+
/** @copydoc void IWebsocketClient::registerListener(IListener&) */
188+
void LibWebsocketClient::registerListener(IListener& listener)
189189
{
190190
m_listener = &listener;
191191
}

src/websockets/libwebsockets/LibWebsocketClient.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -60,8 +60,8 @@ class LibWebsocketClient : public IWebsocketClient
6060
/** @copydoc bool IWebsocketClient::send(const void*, size_t) */
6161
bool send(const void* data, size_t size) override;
6262

63-
/** @copydoc void IWebsocketClient::registerListener(IWebsocketClientListener&) */
64-
void registerListener(IWebsocketClientListener& listener) override;
63+
/** @copydoc void IWebsocketClient::registerListener(IListener&) */
64+
void registerListener(IListener& listener) override;
6565

6666
private:
6767
/** @brief Message to send */
@@ -87,7 +87,7 @@ class LibWebsocketClient : public IWebsocketClient
8787
};
8888

8989
/** @brief Listener */
90-
IWebsocketClientListener* m_listener;
90+
IListener* m_listener;
9191
/** @brief Internal thread */
9292
std::thread* m_thread;
9393
/** @brief Indicate the end of processing to the thread */

src/websockets/stubs/WebsocketClientStub.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -106,8 +106,8 @@ bool WebsocketClientStub::send(const void* data, size_t size)
106106
return returnValue();
107107
}
108108

109-
/** @copydoc void IWebsocketClient::registerListener(IWebsocketClientListener&) */
110-
void WebsocketClientStub::registerListener(IWebsocketClientListener& listener)
109+
/** @copydoc void IWebsocketClient::registerListener(IListener&) */
110+
void WebsocketClientStub::registerListener(IListener& listener)
111111
{
112112
m_listener = &listener;
113113
}

src/websockets/stubs/WebsocketClientStub.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -58,8 +58,8 @@ class WebsocketClientStub : public IWebsocketClient
5858
/** @copydoc bool IWebsocketClient::send(const void*, size_t) */
5959
bool send(const void* data, size_t size) override;
6060

61-
/** @copydoc void IWebsocketClient::registerListener(IWebsocketClientListener&) */
62-
void registerListener(IWebsocketClientListener& listener) override;
61+
/** @copydoc void IWebsocketClient::registerListener(IListener&) */
62+
void registerListener(IListener& listener) override;
6363

6464
/// Stub interface
6565

@@ -127,7 +127,7 @@ class WebsocketClientStub : public IWebsocketClient
127127
/** @brief Sent data size */
128128
size_t m_sent_size;
129129
/** @brief Listener */
130-
IWebsocketClientListener* m_listener;
130+
IListener* m_listener;
131131
/** @brief Indicate that the next call will fail */
132132
bool m_next_call_will_fail;
133133

0 commit comments

Comments
 (0)