struct-function: cleanup analyserl, added test-case

Author: bvdberg

analyser/module_analyser_function.c2

@@ -130,24 +130,17 @@ fn void Analyser.analyseFunction(Analyser* ma, FunctionDecl* fd) {
 
     bool is_typefn = false;
     if (num_params && fd.hasPrefix()) {
-        // check if SF if first arg is (const) Struct*
+        // check if SF if first arg is (const) Struct* or (const) Struct
         // Note: use TypeRef, since it's faster to check
         const Ref* prefix = fd.getPrefix();
         const Decl* pd = prefix.decl;
         assert(pd);
         QualType prefixType = pd.getType();
 
-        bool is_non_static = true;
         TypeRef* ref = params[0].getTypeRef();
         const Ref* param_ref = ref.getUser();
-        if (0 && pd.isStructType()) {
-            // Note: for struct/union it can only be a pointer to that Type.
-            is_non_static = ref.isPointerTo(prefixType.getIndex());
-        } else {    // enum type
-            // Note: for enum types it can be the Type or a pointer to that type
-            is_non_static = ((param_ref && param_ref.decl == prefix.decl) || ref.isPointerTo(prefixType.getIndex()));
-        }
-
+        // Note: for enum types it can be the Type or a pointer to that type
+        bool is_non_static = ((param_ref && param_ref.decl == prefix.decl) || ref.isPointerTo(prefixType.getIndex()));
         if (is_non_static) {
             fd.setCallKind(CallKind.TypeFunc);
             is_typefn = true;

test/functions/struct_functions/struct_by_value.c2

@@ -0,0 +1,33 @@
+// @warnings{no-unused}
+module test;
+
+type Foo struct {
+    i32 a;
+}
+
+fn void Foo.init(Foo* f, i32 a) {
+    f.a = a;
+}
+
+fn i32 Foo.getA(const Foo f) {
+    return f.a;
+}
+
+type Bar struct {
+    Foo f;
+}
+
+fn void Bar.init(Bar* b, i32 a) {
+    b.f.init(a);
+}
+
+fn Foo Bar.getF(Bar b) {
+    return b.f;
+}
+
+fn i32 test1() {
+    Bar b.init(20);
+    return b.getF().getA();
+}
+
+