[IMP] mail_activity_team: Enhance activity notification logic and improve team user assignment

Author: CRogos

mail_activity_team/models/mail_activity.py

@@ -1,8 +1,9 @@
 # Copyright 2018-22 ForgeFlow S.L.
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
 
-from odoo import SUPERUSER_ID, _, api, fields, models
+from odoo import SUPERUSER_ID, api, fields, models
 from odoo.exceptions import ValidationError
+from odoo.tools.misc import get_lang
 
 
 class MailActivity(models.Model):
@@ -47,7 +48,26 @@ def create(self, vals_list):
                 # so if we don't have a user_team_id we don't want user_id too
                 if "user_id" in vals and not vals.get("team_user_id", False):
                     del vals["user_id"]
-        return super().create(vals_list)
+
+        activities = super().create(vals_list)
+
+        # when creating activities for other: send a notification to assigned user;
+        if not self.env.context.get("mail_activity_quick_update"):
+            activities.action_notify_team()
+        return activities
+
+    def write(self, values):
+        new_team_activities = self.env["mail.activity"]
+        if values.get("team_id"):
+            new_team_activities = self.filtered(
+                lambda activity: activity.user_id.id != values.get("team_id")
+            )
+        res = super().write(values)
+        # notify new responsibles
+        if "team_id" in values:
+            if not self.env.context.get("mail_activity_quick_update", False):
+                new_team_activities.action_notify_team()
+        return res
 
     @api.onchange("user_id")
     def _onchange_user_id(self):
@@ -88,7 +108,7 @@ def _check_team_and_user(self):
                 not in activity.team_id.with_context(active_test=False).member_ids
             ):
                 raise ValidationError(
-                    _(
+                    self.env._(
                         "The assigned user %(user_name)s is "
                         "not member of the team %(team_name)s.",
                         user_name=activity.user_id.name,
@@ -105,3 +125,77 @@ def _onchange_activity_type_id(self):
             if self.user_id not in members and members:
                 self.user_id = members[:1]
         return res
+
+    def action_notify_team(self):
+        # Check if any activity has a team with notify_members enabled
+        classified = self._classify_by_model()
+        for model, activity_data in classified.items():
+            records_sudo = self.env[model].sudo().browse(activity_data["record_ids"])
+            activity_data["record_ids"] = (
+                records_sudo.exists().ids
+            )  # in case record was cascade-deleted in DB, skipping unlink override
+        for activity in self:
+            if activity.res_id not in classified[activity.res_model]["record_ids"]:
+                continue
+            if activity.team_id and activity.team_id.notify_members:
+                # Get the record and model description
+                model_description = (
+                    activity.env["ir.model"]._get(activity.res_model).display_name
+                )
+                record = activity.env[activity.res_model].browse(activity.res_id)
+                # Notify each team member except the assigned user and the current user
+                for member in activity.team_id.member_ids.filtered(
+                    lambda m, assigned_user_id=activity.user_id: self.env.uid
+                    not in m.user_ids.ids
+                    and (
+                        not assigned_user_id
+                        or (assigned_user_id and assigned_user_id not in m.user_ids)
+                    )
+                ):
+                    if member.lang:
+                        # Send notification in member's language
+                        activity_ctx = activity.with_context(lang=member.lang)
+                    else:
+                        activity_ctx = activity
+                    body = activity_ctx.env["ir.qweb"]._render(
+                        "mail.message_activity_assigned",
+                        {
+                            "activity": activity_ctx,
+                            "model_description": model_description,
+                            "is_html_empty": lambda x: not x or x == "<p><br></p>",
+                        },
+                        minimal_qcontext=True,
+                    )
+                    record.message_notify(
+                        partner_ids=member.sudo().partner_id.ids,
+                        body=body,
+                        record_name=activity_ctx.res_name,
+                        model_description=model_description,
+                        email_layout_xmlid="mail.mail_notification_layout",
+                        subject=self.env._(
+                            "%(activity_name)s: %(summary)s (Team Activity)",
+                            activity_name=activity_ctx.res_name,
+                            summary=activity_ctx.summary
+                            or activity_ctx.activity_type_id.name,
+                        ),
+                        subtitles=[
+                            self.env._(
+                                "Activity: %s", activity_ctx.activity_type_id.name
+                            ),
+                            self.env._("Team: %s", activity_ctx.team_id.name),
+                            self.env._(
+                                "Deadline: %s",
+                                activity_ctx.date_deadline.strftime(
+                                    get_lang(activity_ctx.env).date_format
+                                )
+                                if hasattr(activity_ctx.date_deadline, "strftime")
+                                else str(activity_ctx.date_deadline),
+                            ),
+                        ],
+                    )
+
+    def action_notify(self):
+        """Override to notify team members when notify_members is enabled."""
+        result = super().action_notify()
+        self.action_notify_team()
+        return result

mail_activity_team/models/mail_activity_team.py

@@ -45,6 +45,11 @@ def _compute_missing_activities(self):
         string="Team Members",
     )
     user_id = fields.Many2one(comodel_name="res.users", string="Team Leader")
+    notify_members = fields.Boolean(
+        default=False,
+        help="When enabled, all team members will be notified "
+        "when an activity is assigned to this team.",
+    )
     count_missing_activities = fields.Integer(
         string="Missing Activities", compute="_compute_missing_activities", default=0
     )