Skip to content

Commit 1d12552

Browse files
committed
Need early feedback
1 parent e0d965a commit 1d12552

File tree

1 file changed

+4
-7
lines changed

1 file changed

+4
-7
lines changed

src/pages/studyView/StudyViewPageStore.ts

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1655,14 +1655,12 @@ export class StudyViewPageStore
16551655
const chartInfo = this._geneSpecificChartMap.get(
16561656
chartMeta.uniqueKey
16571657
);
1658-
// TODO: Replace `any` with GenomicDataCountItem[]
1658+
// TODO: Replace `any` with GenomicDataCountItem[] when the type in the frontend has been updated
16591659
let data: any[] = [];
1660-
// take a look at this function invokeGenomicDataCount() inStudyViewUtils
1661-
16621660
if (!chartInfo || !this.hasFilteredSamples) {
16631661
return;
16641662
}
1665-
//TODO change the method name to something more generic
1663+
16661664
data = await invokeGenomicDataCountIncludeSampleid(
16671665
chartInfo,
16681666
this.filters,
@@ -1682,14 +1680,14 @@ export class StudyViewPageStore
16821680
d.value.toLowerCase()
16831681
);
16841682

1685-
// group them into mutated, not_mutated, not_profiled
1683+
// group them into mutated, not_mutated
16861684
for (const count of allCounts) {
16871685
const sampleIds: string[] = count.sampleIds ?? [];
16881686
if (
16891687
sampleIds.length === 0 ||
16901688
SKIP_VALUES.has(count.value)
16911689
)
1692-
continue; // case of no samples
1690+
continue; // case of no samples or non profile samples
16931691

16941692
const key = NON_MUTATION_VALUES.has(count.value)
16951693
? count.value
@@ -1736,7 +1734,6 @@ export class StudyViewPageStore
17361734
})
17371735
.filter((g): g is SessionGroupData => g !== null)
17381736
.slice(
1739-
// not sure if this slice works for all charts
17401737
0,
17411738
doesChartHaveComparisonGroupsLimit(chartMeta)
17421739
? MAX_GROUPS_IN_SESSION

0 commit comments

Comments
 (0)