feat: Don't allow negative values for expiresIn

alex9smith · alex9smith · commit 3665f837da83 · 2025-07-02T11:40:43.000+01:00
diff --git a/lib/connect-dynamodb.js b/lib/connect-dynamodb.js
@@ -68,7 +68,10 @@ module.exports = function (connect) {
     if (this.reapInterval > 0) {
       this._reap = setInterval(this.reap.bind(this), this.reapInterval);
     }
-    this.expiresIn = null == options.expiresIn ? 0 : options.expiresIn
+    this.expiresIn = null == options.expiresIn ? 0 : Math.max(options.expiresIn, 0)
+    if (options.expiresIn && options.expiresIn < 0) {
+      console.warn("Negative `expiresIn` values are not supported. Reverting to default behaviour")
+    }
   }
 
   /*

Original file line number	Diff line number	Diff line change
`@@ -68,7 +68,10 @@ module.exports = function (connect) {`
`68`	`68`	`if (this.reapInterval > 0) {`
`69`	`69`	`this._reap = setInterval(this.reap.bind(this), this.reapInterval);`
`70`	`70`	`}`
`71`		`- this.expiresIn = null == options.expiresIn ? 0 : options.expiresIn`
	`71`	`+ this.expiresIn = null == options.expiresIn ? 0 : Math.max(options.expiresIn, 0)`
	`72`	`+ if (options.expiresIn && options.expiresIn < 0) {`
	`73`	+ console.warn("Negative `expiresIn` values are not supported. Reverting to default behaviour")
	`74`	`+ }`
`72`	`75`	`}`
`73`	`76`
`74`	`77`	`/*`