Merge pull request #4687 from ZacSharp/pr/1.19.4/fixSilentlibCrash

Calculate item hash only if needed

Author: leijurv

src/launch/java/baritone/launch/mixins/MixinItemStack.java

@@ -45,14 +45,6 @@ private void recalculateHash() {
         baritoneHash = item == null ? -1 : item.hashCode() + getDamageValue();
     }
 
-    @Inject(
-            method = "<init>*",
-            at = @At("RETURN")
-    )
-    private void onInit(CallbackInfo ci) {
-        recalculateHash();
-    }
-
     @Inject(
             method = "setDamageValue",
             at = @At("TAIL")
@@ -63,7 +55,8 @@ private void onItemDamageSet(CallbackInfo ci) {
 
     @Override
     public int getBaritoneHash() {
-        // TODO: figure out why <init> mixin not working, was 0 for some reason
+        // cannot do this in an init mixin because silentlib likes creating new
+        // items in getDamageValue, which we call in recalculateHash
         if (baritoneHash == 0) recalculateHash();
         return baritoneHash;
     }