Remove misleading component_id from Incident resource (#314)

Author: jbrooksuk

src/Http/Resources/Incident.php

@@ -17,10 +17,12 @@ public function toAttributes(Request $request): array
             'guid' => $this->guid,
             'name' => $this->name,
             'message' => $this->message,
-            'component_id' => $this->component_id,
             'visible' => $this->visible,
             'stickied' => $this->stickied,
             'notifications' => $this->notifications,
+            'components_count' => $this->whenCounted('components', function () {
+                return $this->components_count;
+            }),
             'status' => [
                 'human' => $this->latestStatus?->getLabel(),
                 'value' => $this->latestStatus?->value,

tests/Feature/Api/IncidentTest.php

@@ -278,6 +278,10 @@
 
     expect($componentBResource['attributes']['pivot']['component_status']['value'])
         ->toBe(ComponentStatusEnum::major_outage->value);
+
+    // Verify the components relationship is properly returned (no component_id attribute)
+    expect($response->json('data.attributes'))->not->toHaveKey('component_id');
+    expect($response->json('data.relationships.components.data'))->toHaveCount(2);
 });
 
 it('can create an incident with a template', function () {