changes from feedback

Author: AlexJump24

src/Commands/InstallCommand.php

@@ -115,10 +115,23 @@ protected function configureDatabaseSettings(AppSettings $settings): AppSettings
         )
             ->filter(fn (ReflectionProperty $property) => array_key_exists($property->getName(), $settings->installable()) )
             ->each(function (ReflectionProperty $property) use ($settings) {
-                $description = $property->getAttributes(Description::class)[0]->getArguments()[0];
+                $descriptionAttribute = $property->getAttributes(Description::class);
+
+                if (empty($descriptionAttribute)) {
+                    return;
+                }
+
+                $descriptionAttributeClass = $descriptionAttribute[0]->newInstance();
+                $default = $descriptionAttributeClass->getDefault();
+                $required = $descriptionAttributeClass->getRequired();
+
+                if ($required === false) {
+                    return;
+                }
+
                 $value = match($property->getType()?->getName()) {
-                    'bool' => confirm($description ?? $property->getName()),
-                    default => text($description ?? $property->getName(), default: $property->getDefaultValue() ?? '', required: true),
+                    'bool' => confirm($default ?? $property->getName()),
+                    default => text($default ?? $property->getName(), default: $property->getDefaultValue() ?? '', required: true),
                 };
 
                 $settings->{$property->getName()} = $value;

src/Settings/AppSettings.php

@@ -14,7 +14,7 @@ class AppSettings extends Settings
     #[Description('What is the name of your application?')]
     public ?string $name = 'Cachet';
 
-    #[Description('What is your application about?')]
+    #[Description('What is your application about?', required: false)]
     public ?string $about;
 
     #[Description('Do you want to show support for Cachet?')]
@@ -32,7 +32,7 @@ class AppSettings extends Settings
     #[Description('How many incident days should be shown in the timeline?')]
     public int $incident_days = 7;
 
-    #[Description('After how many seconds should the status page automatically refresh?')]
+    #[Description('After how many seconds should the status page automatically refresh?', required: false)]
     public ?int $refresh_rate;
 
     #[Description('Should the dashboard login link be shown?')]

src/Settings/Attributes/Description.php

@@ -7,5 +7,15 @@
 #[Attribute(Attribute::TARGET_PROPERTY)]
 final class Description
 {
-    public function __construct(private string $description) {}
+    public function __construct(private readonly string $default, private readonly bool $required = true) {}
+
+    public function getDefault(): string
+    {
+        return $this->default;
+    }
+
+    public function getRequired(): bool
+    {
+        return $this->required;
+    }
 }

tests/Unit/Commands/InstallCommandTest.php

@@ -26,13 +26,11 @@
         ->expectsQuestion('Which database connection do you wish to use for Cachet?', 'default')
         ->expectsQuestion('Do you wish to send anonymous data to cachet to help us understand how Cachet is used?', true)
         ->expectsQuestion('What is the name of your application?', 'Laravel Envoyer')
-        ->expectsQuestion('What is your application about?', 'Zero downtime deployment tool.')
         ->expectsConfirmation('Do you want to show support for Cachet?', 'yes')
         ->expectsQuestion('What timezone is is the application located in?', 'America/New_York')
         ->expectsConfirmation('Would you like to show your timezone on the status page?', 'yes')
         ->expectsConfirmation('Would you like to only show the days with disruption?', 'yes')
         ->expectsQuestion('How many incident days should be shown in the timeline?', 14)
-        ->expectsQuestion('After how many seconds should the status page automatically refresh?', 10)
         ->expectsConfirmation('Should the dashboard login link be shown?', 'no')
         ->expectsQuestion('Major outage threshold %', 50)
         ->expectsOutputToContain('Installing Cachet...')
@@ -49,13 +47,11 @@
 
     $settings = app(AppSettings::class);
     expect($settings->name)->toBe('Laravel Envoyer')
-        ->and($settings->about)->toBe('Zero downtime deployment tool.')
         ->and($settings->show_support)->toBeTrue()
         ->and($settings->timezone)->toBe('America/New_York')
         ->and($settings->show_timezone)->toBeTrue()
         ->and($settings->only_disrupted_days)->toBeTrue()
         ->and($settings->incident_days)->toBe(14)
-        ->and($settings->refresh_rate)->toBe(10)
         ->and($settings->dashboard_login_link)->toBeFalse()
         ->and($settings->major_outage_threshold)->toBe(50);
 });