Fix unresolved incident scope

Author: jbrooksuk

src/Models/Incident.php

@@ -81,9 +81,9 @@ public function scopeStatus(Builder $query, IncidentStatusEnum $status): Builder
         return $query->where('status', $status);
     }
 
-    public function scopeUnresolved(Builder $builder): Builder
+    public function scopeUnresolved(Builder $query): Builder
     {
-        return $this->whereIn('status', IncidentStatusEnum::unresolved());
+        return $query->whereIn('status', IncidentStatusEnum::unresolved());
     }
 
     /**

tests/Unit/Models/IncidentTest.php

@@ -33,3 +33,15 @@
     expect(Incident::query()->count())->toBe(2)
         ->and(Incident::query()->stickied()->count())->toBe(1);
 });
+
+it('can scope to unresolved incidents', function () {
+    Incident::factory()->sequence(
+        ['status' => IncidentStatusEnum::investigating],
+        ['status' => IncidentStatusEnum::identified],
+        ['status' => IncidentStatusEnum::watching],
+        ['status' => IncidentStatusEnum::fixed],
+    )->count(4)->create();
+
+    expect(Incident::query()->count())->toBe(4)
+        ->and(Incident::query()->unresolved()->count())->toBe(3);
+});