Fix fallback-true pages

Author: better-salmon

.vscode/settings.json

@@ -39,5 +39,8 @@
   },
   "[typescriptreact]": {
     "editor.defaultFormatter": "biomejs.biome"
+  },
+  "[html]": {
+    "editor.defaultFormatter": "esbenp.prettier-vscode"
   }
 }

apps/cache-testing/tests/pages.spec.ts

@@ -3,10 +3,10 @@ import { expect, test } from '@playwright/test';
 
 const paths = [
   '/pages/with-paths/fallback-blocking/200',
-  // '/pages/with-paths/fallback-true/200',
+  '/pages/with-paths/fallback-true/200',
   '/pages/with-paths/fallback-false/200',
   '/pages/no-paths/fallback-blocking/200',
-  // '/pages/no-paths/fallback-true/200',
+  '/pages/no-paths/fallback-true/200',
   // '/pages/no-paths/fallback-false/200', // this fails with native next.js cache
 ];
 

packages/cache-handler/src/cache-handler.ts

@@ -386,6 +386,7 @@ export class CacheHandler implements NextCacheHandler {
 
   static async #readPagesRouterPage(
     cacheKey: string,
+    isFallback: boolean,
   ): Promise<CacheHandlerValue | null> {
     let cacheHandlerValue: CacheHandlerValue | null = null;
     let pageHtmlHandle: fsPromises.FileHandle | null = null;
@@ -417,9 +418,11 @@ export class CacheHandler implements NextCacheHandler {
       const [pageHtmlFile, { mtimeMs }, pageData] = await Promise.all([
         pageHtmlHandle.readFile('utf-8'),
         pageHtmlHandle.stat(),
-        fsPromises
-          .readFile(pageDataPath, 'utf-8')
-          .then((data) => JSON.parse(data) as object),
+        isFallback
+          ? {}
+          : fsPromises
+              .readFile(pageDataPath, 'utf-8')
+              .then((data) => JSON.parse(data) as object),
       ]);
 
       if (CacheHandler.#debug) {
@@ -849,14 +852,21 @@ export class CacheHandler implements NextCacheHandler {
       });
 
     if (!cachedData && CacheHandler.#fallbackFalseRoutes.has(cacheKey)) {
-      cachedData = await CacheHandler.#readPagesRouterPage(cacheKey);
+      cachedData = await CacheHandler.#readPagesRouterPage(cacheKey, false);
 
       // if we have a value from the file system, we should set it to the cache store
       if (cachedData) {
         await CacheHandler.#mergedHandler.set(cacheKey, cachedData);
       }
     }
 
+    if (ctx.isFallback) {
+      cachedData = await CacheHandler.#readPagesRouterPage(
+        cacheKey,
+        ctx.isFallback,
+      );
+    }
+
     return cachedData ?? null;
   }
 

packages/cache-handler/src/use-cache/redis.ts

@@ -417,13 +417,6 @@ function createRedisCacheHandler(config: RedisConfig = {}) {
             errorRetryCount: 0,
           };
 
-          console.info(
-            'entry.expire, entry.revalidate, entry.stale',
-            entry.expire,
-            entry.revalidate,
-            entry.stale,
-          );
-
           // Store in Redis with an expiration
           await redisClient.set(
             getKey(cacheKey),

turbo.json

@@ -6,6 +6,7 @@
   "tasks": {
     "build": {
       "dependsOn": ["^build"],
+      "cache": false,
       "env": [
         "REDIS_URL",
         "REMOTE_CACHE_SERVER_BASE_URL",