Add realm to Proxy-Authenticate header

sergeyfrolov · sergeyfrolov · commit ae59fae1dcab · 2019-02-03T17:23:15.000-07:00
Resolves #52 Squid's default realm is "Squid proxy-caching web server", so I decided to give descriptive realm to Caddy as well.
diff --git a/forwardproxy.go b/forwardproxy.go
@@ -311,7 +311,7 @@ func (fp *ForwardProxy) ServeHTTP(w http.ResponseWriter, r *http.Request) (int,
 			httpserver.WriteSiteNotFound(w, r)
 			return 0, authErr // current Caddy behavior without forwardproxy
 		} else {
-			w.Header().Set("Proxy-Authenticate", "Basic")
+			w.Header().Set("Proxy-Authenticate", "Basic realm=\"Caddy Secure Web Proxy\"")
 			return http.StatusProxyAuthRequired, authErr
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -311,7 +311,7 @@ func (fp ForwardProxy) ServeHTTP(w http.ResponseWriter, r http.Request) (int,`
`311`	`311`	`httpserver.WriteSiteNotFound(w, r)`
`312`	`312`	`return 0, authErr // current Caddy behavior without forwardproxy`
`313`	`313`	`} else {`
`314`		`- w.Header().Set("Proxy-Authenticate", "Basic")`
	`314`	`+ w.Header().Set("Proxy-Authenticate", "Basic realm=\"Caddy Secure Web Proxy\"")`
`315`	`315`	`return http.StatusProxyAuthRequired, authErr`
`316`	`316`	`}`
`317`	`317`	`}`