Auto PRs for release updates #220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taylanisikdemir
approved these changes
Mar 12, 2025
| ref: ${{ env.BRANCH }} | ||
|
|
||
| - name: Fallback to default branch if checkout failed | ||
| if: steps.try-checkout.outcome == 'failure' |
Member
There was a problem hiding this comment.
The potential problem with this approach is that once you create fetch-release-data-update branch and forget to delete it, this workflow will always use that instead of default branch. Might be fine but please document this behavior somewhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the Github action to create a PR for data updates instead of creating commits directly to master branch.
We can't commit directly to master branch due to branch protection rules.
The upside is that all data updates will be reviewed before deployment.
Example of PR:
PR and branch can be deleted and the github action will recreate it if needed using the default branch as the base, this is useful in case history diverges or there is stale data on the branch.