Skipping racy tests (#1375)

3vilhamster · web-flow · commit 163f1a940342 · 2024-11-01T00:42:00.000+01:00
diff --git a/internal/context_test.go b/internal/context_test.go
@@ -74,6 +74,7 @@ func TestContextChildParentCancelRace(t *testing.T) {
 }
 
 func TestContextConcurrentCancelRace(t *testing.T) {
+	t.Skip("This test is racy and not reliable. It is disabled until we can make it reliable.")
 	/*
 		A race condition existed due to concurrently ending goroutines on shutdown (i.e. closing their chan without waiting
 		on them to finish shutdown), which executed... quite a lot of non-concurrency-safe code in a concurrent way.  All
@@ -104,6 +105,7 @@ func TestContextConcurrentCancelRace(t *testing.T) {
 }
 
 func TestContextAddChildCancelParentRace(t *testing.T) {
+	t.Skip("This test is racy and not reliable. It is disabled until we can make it reliable.")
 	/*
 		It's apparently also possible to race on adding children while propagating the cancel to children.
 	*/

Original file line number	Diff line number	Diff line change
`@@ -74,6 +74,7 @@ func TestContextChildParentCancelRace(t *testing.T) {`
`74`	`74`	`}`
`75`	`75`
`76`	`76`	`func TestContextConcurrentCancelRace(t *testing.T) {`
	`77`	`+ t.Skip("This test is racy and not reliable. It is disabled until we can make it reliable.")`
`77`	`78`	`/*`
`78`	`79`	`A race condition existed due to concurrently ending goroutines on shutdown (i.e. closing their chan without waiting`
`79`	`80`	`on them to finish shutdown), which executed... quite a lot of non-concurrency-safe code in a concurrent way. All`
`@@ -104,6 +105,7 @@ func TestContextConcurrentCancelRace(t *testing.T) {`
`104`	`105`	`}`
`105`	`106`
`106`	`107`	`func TestContextAddChildCancelParentRace(t *testing.T) {`
	`108`	`+ t.Skip("This test is racy and not reliable. It is disabled until we can make it reliable.")`
`107`	`109`	`/*`
`108`	`110`	`It's apparently also possible to race on adding children while propagating the cancel to children.`
`109`	`111`	`*/`