Change logging to debug level and add more details to prevent confusion (#1300)

timl3136 · web-flow · commit 16c678e60d42 · 2023-12-04T14:56:33.000-08:00
What changed?
Change warning message for unknown event type to debug level

Why?
It's creating too much warning log that overwhelm system

How did you test it?
Unit test

Potential risks
Only remove logger so no danger
diff --git a/internal/internal_utils.go b/internal/internal_utils.go
@@ -468,10 +468,8 @@ func estimateHistorySize(logger *zap.Logger, event *s.HistoryEvent) int {
 			sum += len(event.SignalExternalWorkflowExecutionInitiatedEventAttributes.Control)
 			sum += len(event.SignalExternalWorkflowExecutionInitiatedEventAttributes.Input)
 		}
-
 	default:
-		logger.Warn("unknown event type", zap.String("Event Type", event.GetEventType().String()))
-		// Do not fail to be forward compatible with new events
+		logger.Debug("unsupported event type for history size estimation", zap.String("Event Type", event.GetEventType().String()))
 	}
 
 	return sum

Original file line number	Diff line number	Diff line change
`@@ -468,10 +468,8 @@ func estimateHistorySize(logger zap.Logger, event s.HistoryEvent) int {`
`468`	`468`	`sum += len(event.SignalExternalWorkflowExecutionInitiatedEventAttributes.Control)`
`469`	`469`	`sum += len(event.SignalExternalWorkflowExecutionInitiatedEventAttributes.Input)`
`470`	`470`	`}`
`471`		`-`
`472`	`471`	`default:`
`473`		`- logger.Warn("unknown event type", zap.String("Event Type", event.GetEventType().String()))`
`474`		`- // Do not fail to be forward compatible with new events`
	`472`	`+ logger.Debug("unsupported event type for history size estimation", zap.String("Event Type", event.GetEventType().String()))`
`475`	`473`	`}`
`476`	`474`
`477`	`475`	`return sum`