Skip to content

Commit 221cc4e

Browse files
authored
rework on poller auto scaler (#1411)
Detailed Description Improve performance of poller auto scaler by using more accurate scaling signals and several implementation changes. Changes New WorkerOptions AutoScalerOptions is introduced. Several WorkerOptions are deprecated and become no-op. read new signal (poller wait time) to scale allow kill switching poller auto scaler from server new implementation that makes scaling quicker to traffic change removed no longer used autoscaler package completely (original implementation is over complicated) Impact Analysis Backward Compatibility: NO existing autoscaling will be stopped but this shall not have big impact since this feature was never rolled out in production. For OSS users, please follow the instructions below in rollout plan. Forward Compatibility: Yes, introduce new Testing Plan Unit Tests: Yes Persistence Tests: Not related Integration Tests: No Compatibility Tests: No, because it's autoscaler is a feature that was not rolled out in production. Rollout Plan What is the rollout plan? For Uber services, standard client release steps For OSS users, turn off autoscaler feature first before the client upgrade. Does the order of deployment matter? No Is it safe to rollback? Does the order of rollback matter? Yes Is there a kill switch to mitigate the impact immediately? Yes, the new autoscaler feature is an opt-in feature.
1 parent 526cb2d commit 221cc4e

18 files changed

+956
-883
lines changed

internal/common/autoscaler/autoscaler.go

Lines changed: 0 additions & 32 deletions
This file was deleted.

internal/common/autoscaler/estimator.go

Lines changed: 0 additions & 30 deletions
This file was deleted.

internal/common/autoscaler/recommender.go

Lines changed: 0 additions & 66 deletions
This file was deleted.

internal/common/autoscaler/recommender_test.go

Lines changed: 0 additions & 144 deletions
This file was deleted.

internal/common/autoscaler/types.go

Lines changed: 0 additions & 50 deletions
This file was deleted.

internal/common/metrics/constants.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -114,4 +114,7 @@ const (
114114
ServerSideHistorySize = CadenceMetricsPrefix + "server-side-history-size"
115115
ConcurrentTaskQuota = CadenceMetricsPrefix + "concurrent-task-quota"
116116
PollerRequestBufferUsage = CadenceMetricsPrefix + "poller-request-buffer-usage"
117+
118+
// Concurrency Auto Scaler
119+
ConcurrencyAutoScalerScope = CadenceMetricsPrefix + "concurrency-auto-scaler"
117120
)

0 commit comments

Comments
 (0)