Skip to content

Commit 26cbfbc

Browse files
committed
remove noop return
1 parent 4adfae7 commit 26cbfbc

File tree

1 file changed

+0
-28
lines changed

1 file changed

+0
-28
lines changed

internal/internal_event_handlers.go

Lines changed: 0 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -979,8 +979,6 @@ func (weh *workflowExecutionEventHandlerImpl) handleActivityTaskCompleted(event
979979
return
980980
}
981981
activity.handle(event.ActivityTaskCompletedEventAttributes.Result, nil)
982-
983-
return
984982
}
985983

986984
func (weh *workflowExecutionEventHandlerImpl) handleActivityTaskFailed(event *m.HistoryEvent) {
@@ -994,7 +992,6 @@ func (weh *workflowExecutionEventHandlerImpl) handleActivityTaskFailed(event *m.
994992
attributes := event.ActivityTaskFailedEventAttributes
995993
err := constructError(*attributes.Reason, attributes.Details, weh.GetDataConverter())
996994
activity.handle(nil, err)
997-
return
998995
}
999996

1000997
func (weh *workflowExecutionEventHandlerImpl) handleActivityTaskTimedOut(event *m.HistoryEvent) {
@@ -1017,7 +1014,6 @@ func (weh *workflowExecutionEventHandlerImpl) handleActivityTaskTimedOut(event *
10171014
err = NewTimeoutError(attributes.GetTimeoutType(), details)
10181015
}
10191016
activity.handle(nil, err)
1020-
return
10211017
}
10221018

10231019
func (weh *workflowExecutionEventHandlerImpl) handleActivityTaskCanceled(event *m.HistoryEvent) {
@@ -1034,8 +1030,6 @@ func (weh *workflowExecutionEventHandlerImpl) handleActivityTaskCanceled(event *
10341030
err := NewCanceledError(details)
10351031
activity.handle(nil, err)
10361032
}
1037-
1038-
return
10391033
}
10401034

10411035
func (weh *workflowExecutionEventHandlerImpl) handleTimerFired(event *m.HistoryEvent) {
@@ -1184,8 +1178,6 @@ func (weh *workflowExecutionEventHandlerImpl) handleStartChildWorkflowExecutionF
11841178
}
11851179
childWorkflow.startedCallback(WorkflowExecution{}, err)
11861180
childWorkflow.handle(nil, err)
1187-
1188-
return
11891181
}
11901182

11911183
func (weh *workflowExecutionEventHandlerImpl) handleChildWorkflowExecutionStarted(event *m.HistoryEvent) {
@@ -1203,8 +1195,6 @@ func (weh *workflowExecutionEventHandlerImpl) handleChildWorkflowExecutionStarte
12031195
RunID: childRunID,
12041196
}
12051197
childWorkflow.startedCallback(childWorkflowExecution, nil)
1206-
1207-
return
12081198
}
12091199

12101200
func (weh *workflowExecutionEventHandlerImpl) handleChildWorkflowExecutionCompleted(event *m.HistoryEvent) {
@@ -1216,8 +1206,6 @@ func (weh *workflowExecutionEventHandlerImpl) handleChildWorkflowExecutionComple
12161206
return
12171207
}
12181208
childWorkflow.handle(attributes.Result, nil)
1219-
1220-
return
12211209
}
12221210

12231211
func (weh *workflowExecutionEventHandlerImpl) handleChildWorkflowExecutionFailed(event *m.HistoryEvent) {
@@ -1231,8 +1219,6 @@ func (weh *workflowExecutionEventHandlerImpl) handleChildWorkflowExecutionFailed
12311219

12321220
err := constructError(attributes.GetReason(), attributes.Details, weh.GetDataConverter())
12331221
childWorkflow.handle(nil, err)
1234-
1235-
return
12361222
}
12371223

12381224
func (weh *workflowExecutionEventHandlerImpl) handleChildWorkflowExecutionCanceled(event *m.HistoryEvent) {
@@ -1246,7 +1232,6 @@ func (weh *workflowExecutionEventHandlerImpl) handleChildWorkflowExecutionCancel
12461232
details := newEncodedValues(attributes.Details, weh.GetDataConverter())
12471233
err := NewCanceledError(details)
12481234
childWorkflow.handle(nil, err)
1249-
return
12501235
}
12511236

12521237
func (weh *workflowExecutionEventHandlerImpl) handleChildWorkflowExecutionTimedOut(event *m.HistoryEvent) {
@@ -1259,8 +1244,6 @@ func (weh *workflowExecutionEventHandlerImpl) handleChildWorkflowExecutionTimedO
12591244
}
12601245
err := NewTimeoutError(attributes.GetTimeoutType())
12611246
childWorkflow.handle(nil, err)
1262-
1263-
return
12641247
}
12651248

12661249
func (weh *workflowExecutionEventHandlerImpl) handleChildWorkflowExecutionTerminated(event *m.HistoryEvent) {
@@ -1273,8 +1256,6 @@ func (weh *workflowExecutionEventHandlerImpl) handleChildWorkflowExecutionTermin
12731256
}
12741257
err := newTerminatedError()
12751258
childWorkflow.handle(nil, err)
1276-
1277-
return
12781259
}
12791260

12801261
func (weh *workflowExecutionEventHandlerImpl) handleUpsertWorkflowSearchAttributes(event *m.HistoryEvent) {
@@ -1288,7 +1269,6 @@ func (weh *workflowExecutionEventHandlerImpl) handleRequestCancelExternalWorkflo
12881269
workflowID := attribute.WorkflowExecution.GetWorkflowId()
12891270
cancellationID := string(attribute.Control)
12901271
weh.decisionsHelper.handleRequestCancelExternalWorkflowExecutionInitiated(event.GetEventId(), workflowID, cancellationID)
1291-
return
12921272
}
12931273

12941274
func (weh *workflowExecutionEventHandlerImpl) handleExternalWorkflowExecutionCancelRequested(event *m.HistoryEvent) {
@@ -1305,8 +1285,6 @@ func (weh *workflowExecutionEventHandlerImpl) handleExternalWorkflowExecutionCan
13051285
}
13061286
cancellation.handle(nil, nil)
13071287
}
1308-
1309-
return
13101288
}
13111289

13121290
func (weh *workflowExecutionEventHandlerImpl) handleRequestCancelExternalWorkflowExecutionFailed(event *m.HistoryEvent) {
@@ -1324,8 +1302,6 @@ func (weh *workflowExecutionEventHandlerImpl) handleRequestCancelExternalWorkflo
13241302
err := fmt.Errorf("cancel external workflow failed, %v", attributes.GetCause())
13251303
cancellation.handle(nil, err)
13261304
}
1327-
1328-
return
13291305
}
13301306

13311307
func (weh *workflowExecutionEventHandlerImpl) handleSignalExternalWorkflowExecutionCompleted(event *m.HistoryEvent) {
@@ -1336,8 +1312,6 @@ func (weh *workflowExecutionEventHandlerImpl) handleSignalExternalWorkflowExecut
13361312
return
13371313
}
13381314
signal.handle(nil, nil)
1339-
1340-
return
13411315
}
13421316

13431317
func (weh *workflowExecutionEventHandlerImpl) handleSignalExternalWorkflowExecutionFailed(event *m.HistoryEvent) {
@@ -1357,6 +1331,4 @@ func (weh *workflowExecutionEventHandlerImpl) handleSignalExternalWorkflowExecut
13571331
}
13581332

13591333
signal.handle(nil, err)
1360-
1361-
return
13621334
}

0 commit comments

Comments
 (0)