Add missing mappers for CronOverlapPolicy and ActiveCluster (#1450)

Author: timl3136

internal/compatibility/proto/decision.go

@@ -142,6 +142,8 @@ func Decision(d *shared.Decision) *apiv1.Decision {
 				Memo:                         Memo(attr.Memo),
 				SearchAttributes:             SearchAttributes(attr.SearchAttributes),
 				JitterStart:                  secondsToDuration(attr.JitterStartSeconds),
+				CronOverlapPolicy:            CronOverlapPolicy(attr.CronOverlapPolicy),
+				ActiveClusterSelectionPolicy: ActiveClusterSelectionPolicy(attr.ActiveClusterSelectionPolicy),
 			},
 		}
 	case shared.DecisionTypeStartChildWorkflowExecution:
@@ -163,6 +165,8 @@ func Decision(d *shared.Decision) *apiv1.Decision {
 				Header:                       Header(attr.Header),
 				Memo:                         Memo(attr.Memo),
 				SearchAttributes:             SearchAttributes(attr.SearchAttributes),
+				CronOverlapPolicy:            CronOverlapPolicy(attr.CronOverlapPolicy),
+				ActiveClusterSelectionPolicy: ActiveClusterSelectionPolicy(attr.ActiveClusterSelectionPolicy),
 			},
 		}
 	case shared.DecisionTypeSignalExternalWorkflowExecution:

internal/compatibility/proto/types.go

@@ -417,6 +417,7 @@ func WorkflowExecutionInfo(t *shared.WorkflowExecutionInfo) *apiv1.WorkflowExecu
 		AutoResetPoints:     ResetPoints(t.AutoResetPoints),
 		TaskList:            t.GetTaskList(),
 		IsCron:              t.GetIsCron(),
+		CronOverlapPolicy:   CronOverlapPolicy(t.CronOverlapPolicy),
 	}
 }
 

internal/compatibility/testdata/common.go

@@ -48,6 +48,7 @@ const (
 	HostName             = "HostName"
 	Identity             = "Identity"
 	CronSchedule         = "CronSchedule"
+	CronOverlapPolicy    = 0
 	Checksum             = "Checksum"
 	Reason               = "Reason"
 	Cause                = "Cause"

internal/compatibility/testdata/decision.go

@@ -106,6 +106,8 @@ var (
 		Memo:                         &Memo,
 		SearchAttributes:             &SearchAttributes,
 		JitterStart:                  Duration4,
+		CronOverlapPolicy:            apiv1.CronOverlapPolicy_CRON_OVERLAP_POLICY_SKIPPED,
+		ActiveClusterSelectionPolicy: ActiveClusterSelectionPolicyRegionSticky,
 	}
 	FailWorkflowExecutionDecisionAttributes = apiv1.FailWorkflowExecutionDecisionAttributes{
 		Failure: &Failure,
@@ -162,6 +164,8 @@ var (
 		Header:                       &Header,
 		Memo:                         &Memo,
 		SearchAttributes:             &SearchAttributes,
+		CronOverlapPolicy:            apiv1.CronOverlapPolicy_CRON_OVERLAP_POLICY_SKIPPED,
+		ActiveClusterSelectionPolicy: ActiveClusterSelectionPolicyRegionSticky,
 	}
 	StartTimerDecisionAttributes = apiv1.StartTimerDecisionAttributes{
 		TimerId:            TimerID,

internal/compatibility/thrift/decision.go

@@ -136,6 +136,8 @@ func Decision(d *apiv1.Decision) *shared.Decision {
 			Memo:                                Memo(a.Memo),
 			SearchAttributes:                    SearchAttributes(a.SearchAttributes),
 			JitterStartSeconds:                  durationToSeconds(a.JitterStart),
+			CronOverlapPolicy:                   CronOverlapPolicy(a.CronOverlapPolicy),
+			ActiveClusterSelectionPolicy:        ActiveClusterSelectionPolicy(a.ActiveClusterSelectionPolicy),
 		}
 	case *apiv1.Decision_StartChildWorkflowExecutionDecisionAttributes:
 		decision.DecisionType = shared.DecisionTypeStartChildWorkflowExecution.Ptr()
@@ -156,6 +158,8 @@ func Decision(d *apiv1.Decision) *shared.Decision {
 			Header:                              Header(a.Header),
 			Memo:                                Memo(a.Memo),
 			SearchAttributes:                    SearchAttributes(a.SearchAttributes),
+			CronOverlapPolicy:                   CronOverlapPolicy(a.CronOverlapPolicy),
+			ActiveClusterSelectionPolicy:        ActiveClusterSelectionPolicy(a.ActiveClusterSelectionPolicy),
 		}
 	case *apiv1.Decision_SignalExternalWorkflowExecutionDecisionAttributes:
 		decision.DecisionType = shared.DecisionTypeSignalExternalWorkflowExecution.Ptr()

internal/compatibility/thrift/types.go

@@ -421,20 +421,22 @@ func WorkflowExecutionInfo(t *apiv1.WorkflowExecutionInfo) *shared.WorkflowExecu
 		return nil
 	}
 	return &shared.WorkflowExecutionInfo{
-		Execution:        WorkflowExecution(t.WorkflowExecution),
-		Type:             WorkflowType(t.Type),
-		StartTime:        timeToUnixNano(t.StartTime),
-		CloseTime:        timeToUnixNano(t.CloseTime),
-		CloseStatus:      WorkflowExecutionCloseStatus(t.CloseStatus),
-		HistoryLength:    &t.HistoryLength,
-		ParentDomainId:   ParentDomainID(t.ParentExecutionInfo),
-		ParentExecution:  ParentWorkflowExecution(t.ParentExecutionInfo),
-		ExecutionTime:    timeToUnixNano(t.ExecutionTime),
-		Memo:             Memo(t.Memo),
-		SearchAttributes: SearchAttributes(t.SearchAttributes),
-		AutoResetPoints:  ResetPoints(t.AutoResetPoints),
-		TaskList:         &t.TaskList,
-		IsCron:           &t.IsCron,
+		Execution:                    WorkflowExecution(t.WorkflowExecution),
+		Type:                         WorkflowType(t.Type),
+		StartTime:                    timeToUnixNano(t.StartTime),
+		CloseTime:                    timeToUnixNano(t.CloseTime),
+		CloseStatus:                  WorkflowExecutionCloseStatus(t.CloseStatus),
+		HistoryLength:                &t.HistoryLength,
+		ParentDomainId:               ParentDomainID(t.ParentExecutionInfo),
+		ParentExecution:              ParentWorkflowExecution(t.ParentExecutionInfo),
+		ExecutionTime:                timeToUnixNano(t.ExecutionTime),
+		Memo:                         Memo(t.Memo),
+		SearchAttributes:             SearchAttributes(t.SearchAttributes),
+		AutoResetPoints:              ResetPoints(t.AutoResetPoints),
+		TaskList:                     &t.TaskList,
+		IsCron:                       &t.IsCron,
+		CronOverlapPolicy:            CronOverlapPolicy(t.CronOverlapPolicy),
+		ActiveClusterSelectionPolicy: ActiveClusterSelectionPolicy(t.ActiveClusterSelectionPolicy),
 	}
 }
 

internal/internal_workflow.go

@@ -183,6 +183,7 @@ type (
 		dataConverter                       DataConverter
 		retryPolicy                         *shared.RetryPolicy
 		cronSchedule                        string
+		cronOverlapPolicy                   shared.CronOverlapPolicy
 		contextPropagators                  []ContextPropagator
 		memo                                map[string]interface{}
 		searchAttributes                    map[string]interface{}

internal/internal_workflow_testsuite.go

@@ -191,9 +191,10 @@ type (
 		workerStopChannel  chan struct{}
 		sessionEnvironment *testSessionEnvironmentImpl
 
-		cronSchedule   string
-		cronIterations int
-		workflowInput  []byte
+		cronSchedule      string
+		cronIterations    int
+		workflowInput     []byte
+		cronOverlapPolicy shared.CronOverlapPolicy
 	}
 
 	testSessionEnvironmentImpl struct {
@@ -391,6 +392,7 @@ func (env *testWorkflowEnvironmentImpl) newTestWorkflowEnvironmentForChild(param
 	childEnv.workflowInfo.ParentWorkflowDomain = &env.workflowInfo.Domain
 	childEnv.workflowInfo.ParentWorkflowExecution = &env.workflowInfo.WorkflowExecution
 	childEnv.executionTimeout = time.Duration(*params.executionStartToCloseTimeoutSeconds) * time.Second
+	childEnv.cronOverlapPolicy = params.cronOverlapPolicy
 	if workflowHandler, ok := env.runningWorkflows[params.workflowID]; ok {
 		// duplicate workflow ID
 		if !workflowHandler.handled {