cov

Author: Shaddoll

internal/compatibility/api_test.go

@@ -584,9 +584,6 @@ func TestDescribeDomainResponse(t *testing.T) {
 					}
 				},
 			},
-			ExcludedFields: []string{
-				"ActiveClusters", // [BUG,NEEDS INVESTIGATION] Appears to be a nil pointer dereference in mapper conversion
-			},
 		},
 	)
 }
@@ -2019,11 +2016,6 @@ func TestStartWorkflowExecutionRequest(t *testing.T) {
 					c.Fuzz(&req.CronOverlapPolicy)
 				},
 			},
-			ExcludedFields: []string{
-				// [BUG,NEEDS INVESTIGATION] ActiveClusterSelectionPolicy appears to be failing the round trip
-				// TODO: Investigate the mappers and determine where it is failing fuzz testing
-				"ActiveClusterSelectionPolicy",
-			},
 		},
 	)
 }
@@ -2264,10 +2256,9 @@ func TestUpdateDomainRequest(t *testing.T) {
 				},
 			},
 			ExcludedFields: []string{
-				"UpdateMask",     // [NOT INVESTIGATED] Complex nested structure with protobuf metadata issues - mapper incorrectly populates UpdateMask paths
-				"BadBinaries",    // [NOT INVESTIGATED] Appears to be a fuzzing issue, tested in TestBadBinaries
-				"Clusters",       // [NOT INVESTIGATED] Appears to be a fuzzing issue
-				"ActiveClusters", // [NOT INVESTIGATED] Appears to be a fuzzing issue
+				"UpdateMask",  // [NOT INVESTIGATED] Complex nested structure with protobuf metadata issues - mapper incorrectly populates UpdateMask paths
+				"BadBinaries", // [NOT INVESTIGATED] Appears to be a fuzzing issue, tested in TestBadBinaries
+				"Clusters",    // [NOT INVESTIGATED] Appears to be a fuzzing issue
 			},
 		},
 	)
@@ -2304,7 +2295,6 @@ func TestUpdateDomainResponse(t *testing.T) {
 			},
 			ExcludedFields: []string{
 				// Exclude nested fields that have complex issues like in DescribeDomainResponse
-				"Domain.ActiveClusters",      // [BUG,NEEDS INVESTIGATION] Nil pointer dereference in mapper conversion
 				"Domain.Clusters",            // [NOT INVESTIGATED] Protobuf metadata issues in nested ClusterReplicationConfiguration
 				"Domain.FailoverInfo",        // [NOT INVESTIGATED] Protobuf metadata issues in nested structures
 				"Domain.IsolationGroups",     // [NOT INVESTIGATED] Protobuf metadata issues in nested structures

internal/compatibility/enum_test.go

@@ -347,3 +347,14 @@ func TestCronOverlapPolicy(t *testing.T) {
 	}
 	assert.Equal(t, apiv1.CronOverlapPolicy_CRON_OVERLAP_POLICY_INVALID, proto.CronOverlapPolicy(thrift.CronOverlapPolicy(999)))
 }
+
+func TestFailoverType(t *testing.T) {
+	for _, v := range []apiv1.FailoverType{
+		apiv1.FailoverType_FAILOVER_TYPE_INVALID,
+		apiv1.FailoverType_FAILOVER_TYPE_FORCE,
+		apiv1.FailoverType_FAILOVER_TYPE_GRACEFUL,
+	} {
+		assert.Equal(t, v, proto.FailoverType(thrift.FailoverType(v)))
+	}
+	assert.Equal(t, apiv1.FailoverType_FAILOVER_TYPE_INVALID, proto.FailoverType(thrift.FailoverType(999)))
+}

internal/compatibility/proto/enum.go

@@ -408,3 +408,18 @@ func CronOverlapPolicy(t *shared.CronOverlapPolicy) apiv1.CronOverlapPolicy {
 	}
 	return apiv1.CronOverlapPolicy_CRON_OVERLAP_POLICY_INVALID
 }
+
+func FailoverType(t *shared.FailoverType) apiv1.FailoverType {
+	if t == nil {
+		return apiv1.FailoverType_FAILOVER_TYPE_INVALID
+	}
+	switch *t {
+	case shared.FailoverTypeInvalid:
+		return apiv1.FailoverType_FAILOVER_TYPE_INVALID
+	case shared.FailoverTypeForce:
+		return apiv1.FailoverType_FAILOVER_TYPE_FORCE
+	case shared.FailoverTypeGraceful:
+		return apiv1.FailoverType_FAILOVER_TYPE_GRACEFUL
+	}
+	return apiv1.FailoverType_FAILOVER_TYPE_INVALID
+}