Simplify worker options configuration value propagation (#1179)

* rename workerExecutionParameters fields to match WorkerOptions

* use embedding of WorkerOptions to make assignment easier

* fix test

* rename workflowInterceptors to workflowInterceptorFactories

Author: shijiesheng

internal/common/autoscaler/auto_scaler.go

@@ -0,0 +1 @@
+package autoscaler

internal/interceptors.go

@@ -72,7 +72,7 @@ type WorkflowInterceptor interface {
 
 var _ WorkflowInterceptor = (*WorkflowInterceptorBase)(nil)
 
-// WorkflowInterceptorBase is a helper type that can simplify creation of WorkflowInterceptors
+// WorkflowInterceptorBase is a helper type that can simplify creation of WorkflowInterceptorChainFactories
 type WorkflowInterceptorBase struct {
 	Next WorkflowInterceptor
 }

internal/internal_event_handlers.go

@@ -112,12 +112,12 @@ type (
 		isReplay              bool // flag to indicate if workflow is in replay mode
 		enableLoggingInReplay bool // flag to indicate if workflow should enable logging in replay mode
 
-		metricsScope         tally.Scope
-		registry             *registry
-		dataConverter        DataConverter
-		contextPropagators   []ContextPropagator
-		tracer               opentracing.Tracer
-		workflowInterceptors []WorkflowInterceptorFactory
+		metricsScope                 tally.Scope
+		registry                     *registry
+		dataConverter                DataConverter
+		contextPropagators           []ContextPropagator
+		tracer                       opentracing.Tracer
+		workflowInterceptorFactories []WorkflowInterceptorFactory
 	}
 
 	localActivityTask struct {
@@ -201,24 +201,24 @@ func newWorkflowExecutionEventHandler(
 	dataConverter DataConverter,
 	contextPropagators []ContextPropagator,
 	tracer opentracing.Tracer,
-	workflowInterceptors []WorkflowInterceptorFactory,
+	workflowInterceptorFactories []WorkflowInterceptorFactory,
 ) workflowExecutionEventHandler {
 	context := &workflowEnvironmentImpl{
-		workflowInfo:          workflowInfo,
-		decisionsHelper:       newDecisionsHelper(),
-		sideEffectResult:      make(map[int32][]byte),
-		mutableSideEffect:     make(map[string][]byte),
-		changeVersions:        make(map[string]Version),
-		pendingLaTasks:        make(map[string]*localActivityTask),
-		unstartedLaTasks:      make(map[string]struct{}),
-		openSessions:          make(map[string]*SessionInfo),
-		completeHandler:       completeHandler,
-		enableLoggingInReplay: enableLoggingInReplay,
-		registry:              registry,
-		dataConverter:         dataConverter,
-		contextPropagators:    contextPropagators,
-		tracer:                tracer,
-		workflowInterceptors:  workflowInterceptors,
+		workflowInfo:                 workflowInfo,
+		decisionsHelper:              newDecisionsHelper(),
+		sideEffectResult:             make(map[int32][]byte),
+		mutableSideEffect:            make(map[string][]byte),
+		changeVersions:               make(map[string]Version),
+		pendingLaTasks:               make(map[string]*localActivityTask),
+		unstartedLaTasks:             make(map[string]struct{}),
+		openSessions:                 make(map[string]*SessionInfo),
+		completeHandler:              completeHandler,
+		enableLoggingInReplay:        enableLoggingInReplay,
+		registry:                     registry,
+		dataConverter:                dataConverter,
+		contextPropagators:           contextPropagators,
+		tracer:                       tracer,
+		workflowInterceptorFactories: workflowInterceptorFactories,
 	}
 	context.logger = logger.With(
 		zapcore.Field{Key: tagWorkflowType, Type: zapcore.StringType, String: workflowInfo.WorkflowType.Name},
@@ -771,7 +771,7 @@ func (wc *workflowEnvironmentImpl) GetRegistry() *registry {
 }
 
 func (wc *workflowEnvironmentImpl) GetWorkflowInterceptors() []WorkflowInterceptorFactory {
-	return wc.workflowInterceptors
+	return wc.workflowInterceptorFactories
 }
 
 func (weh *workflowExecutionEventHandlerImpl) ProcessEvent(

internal/internal_task_handlers.go

@@ -125,7 +125,7 @@ type (
 		dataConverter                  DataConverter
 		contextPropagators             []ContextPropagator
 		tracer                         opentracing.Tracer
-		workflowInterceptors           []WorkflowInterceptorFactory
+		workflowInterceptorFactories   []WorkflowInterceptorFactory
 	}
 
 	activityProvider func(name string) activity
@@ -396,7 +396,7 @@ func newWorkflowTaskHandler(
 		dataConverter:                  params.DataConverter,
 		contextPropagators:             params.ContextPropagators,
 		tracer:                         params.Tracer,
-		workflowInterceptors:           params.WorkflowInterceptors,
+		workflowInterceptorFactories:   params.WorkflowInterceptorChainFactories,
 	}
 }
 
@@ -591,7 +591,7 @@ func (w *workflowExecutionContextImpl) createEventHandler() {
 		w.wth.dataConverter,
 		w.wth.contextPropagators,
 		w.wth.tracer,
-		w.wth.workflowInterceptors,
+		w.wth.workflowInterceptorFactories,
 	)
 	w.eventHandler.Store(eventHandler)
 }