Skip to content

Commit 54cedf4

Browse files
committed
Manually compact some import-groups so goimports will maintain them more nicely
Somewhat surprisingly, goimports does not have a way to forcefully merge groups into its 3-tier structure. Personally I'd like to do that for consistency, allowing separate groups only if documented. But meh. They're kinda unlikely to degrade, and it doesn't really matter if they do.
1 parent 81ed30c commit 54cedf4

File tree

6 files changed

+12
-23
lines changed

6 files changed

+12
-23
lines changed

internal/common/auth/service_wrapper_test.go

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -25,15 +25,12 @@ import (
2525
"testing"
2626
"time"
2727

28-
"github.com/uber/tchannel-go/thrift"
29-
30-
"go.uber.org/cadence/.gen/go/shared"
31-
3228
"github.com/golang/mock/gomock"
29+
"github.com/stretchr/testify/suite"
30+
"github.com/uber/tchannel-go/thrift"
3331

3432
"go.uber.org/cadence/.gen/go/cadence/workflowservicetest"
35-
36-
"github.com/stretchr/testify/suite"
33+
"go.uber.org/cadence/.gen/go/shared"
3734
)
3835

3936
type (

internal/compatibility/enum_test.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,12 +24,11 @@ import (
2424
"testing"
2525

2626
"github.com/stretchr/testify/assert"
27+
apiv1 "github.com/uber/cadence-idl/go/proto/api/v1"
2728

2829
"go.uber.org/cadence/.gen/go/shared"
2930
"go.uber.org/cadence/internal/compatibility/proto"
3031
"go.uber.org/cadence/internal/compatibility/thrift"
31-
32-
apiv1 "github.com/uber/cadence-idl/go/proto/api/v1"
3332
)
3433

3534
const UnknownValue = 9999

internal/compatibility/proto/error.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,12 +21,11 @@
2121
package proto
2222

2323
import (
24+
apiv1 "github.com/uber/cadence-idl/go/proto/api/v1"
2425
"go.uber.org/yarpc/encoding/protobuf"
2526
"go.uber.org/yarpc/yarpcerrors"
2627

2728
"go.uber.org/cadence/.gen/go/shared"
28-
29-
apiv1 "github.com/uber/cadence-idl/go/proto/api/v1"
3029
)
3130

3231
func Error(err error) error {

internal/compatibility/thrift/error.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,13 +23,12 @@ package thrift
2323
import (
2424
"errors"
2525

26+
apiv1 "github.com/uber/cadence-idl/go/proto/api/v1"
2627
"go.uber.org/yarpc/encoding/protobuf"
2728
"go.uber.org/yarpc/yarpcerrors"
2829

2930
"go.uber.org/cadence/.gen/go/shared"
3031
"go.uber.org/cadence/internal/common"
31-
32-
apiv1 "github.com/uber/cadence-idl/go/proto/api/v1"
3332
)
3433

3534
func Error(err error) error {

internal/internal_workflow_client_test.go

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -29,19 +29,16 @@ import (
2929
"testing"
3030
"time"
3131

32+
"github.com/golang/mock/gomock"
33+
"github.com/pborman/uuid"
34+
"github.com/stretchr/testify/suite"
3235
"go.uber.org/yarpc"
3336

34-
"go.uber.org/cadence/internal/common/serializer"
35-
3637
"go.uber.org/cadence/.gen/go/cadence/workflowservicetest"
3738
"go.uber.org/cadence/.gen/go/shared"
3839
"go.uber.org/cadence/internal/common"
39-
40-
"github.com/golang/mock/gomock"
41-
"github.com/pborman/uuid"
42-
"github.com/stretchr/testify/suite"
43-
4440
"go.uber.org/cadence/internal/common/metrics"
41+
"go.uber.org/cadence/internal/common/serializer"
4542
)
4643

4744
const (

test/integration_test.go

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,20 +30,18 @@ import (
3030
"testing"
3131
"time"
3232

33-
"github.com/uber-go/tally"
34-
35-
"go.uber.org/cadence/internal"
36-
3733
"github.com/pborman/uuid"
3834
"github.com/stretchr/testify/require"
3935
"github.com/stretchr/testify/suite"
36+
"github.com/uber-go/tally"
4037
"go.uber.org/goleak"
4138
"go.uber.org/zap/zaptest"
4239

4340
"go.uber.org/cadence"
4441
"go.uber.org/cadence/.gen/go/shared"
4542
"go.uber.org/cadence/client"
4643
"go.uber.org/cadence/interceptors"
44+
"go.uber.org/cadence/internal"
4745
"go.uber.org/cadence/worker"
4846
"go.uber.org/cadence/workflow"
4947
)

0 commit comments

Comments
 (0)