Skip to content

Commit 61e8079

Browse files
committed
Fixing panics in test activities
1 parent bcd0462 commit 61e8079

File tree

3 files changed

+13
-0
lines changed

3 files changed

+13
-0
lines changed

internal/internal_task_handlers.go

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1406,6 +1406,12 @@ func newActivityTaskHandlerWithCustomProvider(
14061406
registry *registry,
14071407
activityProvider activityProvider,
14081408
) ActivityTaskHandler {
1409+
if params.Tracer == nil {
1410+
params.Tracer = opentracing.NoopTracer{}
1411+
}
1412+
if params.WorkerStats.ActivityTracker == nil {
1413+
params.WorkerStats.ActivityTracker = debug.NewNoopActivityTracker()
1414+
}
14091415
return &activityTaskHandlerImpl{
14101416
taskListName: params.TaskList,
14111417
identity: params.Identity,

internal/internal_task_pollers.go

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -525,6 +525,12 @@ func (wtp *workflowTaskPoller) RespondTaskCompleted(completedRequest interface{}
525525
}
526526

527527
func newLocalActivityPoller(params workerExecutionParameters, laTunnel *localActivityTunnel) *localActivityTaskPoller {
528+
if params.Tracer == nil {
529+
params.Tracer = opentracing.NoopTracer{}
530+
}
531+
if params.WorkerStats.ActivityTracker == nil {
532+
params.WorkerStats.ActivityTracker = debug.NewNoopActivityTracker()
533+
}
528534
handler := &localActivityTaskHandler{
529535
userContext: params.UserContext,
530536
metricsScope: metrics.NewTaggedScope(params.MetricsScope),

internal/internal_worker_test.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -274,6 +274,7 @@ func (s *internalWorkerTestSuite) TestNoActivitiesOrWorkflows() {
274274
assert.Empty(t, w.registry.getRegisteredActivities())
275275
assert.Empty(t, w.registry.GetRegisteredWorkflowTypes())
276276
assert.NoError(t, w.Start())
277+
w.Stop()
277278
}
278279

279280
func (s *internalWorkerTestSuite) TestWorkerStartFailsWithInvalidDomain() {

0 commit comments

Comments
 (0)