remove redundant error return value

Author: c-warren

client/client.go

@@ -255,7 +255,7 @@ type (
 		//  - EntityNotExistsError
 		//  - BadRequestError
 		//  - InternalServiceError
-		GetWorkflowHistoryWithOptions(ctx context.Context, request *GetWorkflowHistoryWithOptionsRequest) (HistoryEventIterator, error)
+		GetWorkflowHistoryWithOptions(ctx context.Context, request *GetWorkflowHistoryWithOptionsRequest) HistoryEventIterator
 
 		// CompleteActivity reports activity completed.
 		// activity Execute method can return activity.ErrResultPending to

internal/client.go

@@ -226,7 +226,7 @@ type (
 		//  - EntityNotExistsError
 		//  - BadRequestError
 		//  - InternalServiceError
-		GetWorkflowHistoryWithOptions(ctx context.Context, request *GetWorkflowHistoryWithOptionsRequest) (HistoryEventIterator, error)
+		GetWorkflowHistoryWithOptions(ctx context.Context, request *GetWorkflowHistoryWithOptionsRequest) HistoryEventIterator
 
 		// CompleteActivity reports activity completed.
 		// activity Execute method can return acitivity.activity.ErrResultPending to

internal/internal_workflow_client.go

@@ -480,7 +480,7 @@ func (wc *workflowClient) GetWorkflowHistory(
 		FilterType:            filterType,
 		QueryConsistencyLevel: QueryConsistencyLevelUnspecified,
 	}
-	iter, _ := wc.GetWorkflowHistoryWithOptions(ctx, request)
+	iter := wc.GetWorkflowHistoryWithOptions(ctx, request)
 	return iter
 }
 
@@ -490,7 +490,7 @@ func (wc *workflowClient) GetWorkflowHistory(
 //   - EntityNotExistsError
 //   - BadRequestError
 //   - InternalServiceError
-func (wc *workflowClient) GetWorkflowHistoryWithOptions(ctx context.Context, request *GetWorkflowHistoryWithOptionsRequest) (HistoryEventIterator, error) {
+func (wc *workflowClient) GetWorkflowHistoryWithOptions(ctx context.Context, request *GetWorkflowHistoryWithOptionsRequest) HistoryEventIterator {
 	domain := wc.domain
 	paginate := func(nextToken []byte) (*s.GetWorkflowExecutionHistoryResponse, error) {
 		req := &s.GetWorkflowExecutionHistoryRequest{
@@ -567,7 +567,7 @@ func (wc *workflowClient) GetWorkflowHistoryWithOptions(ctx context.Context, req
 
 	return &historyEventIteratorImpl{
 		paginate: paginate,
-	}, nil
+	}
 }
 
 func isEntityNonExistFromPassive(err error) bool {

internal/internal_workflow_client_test.go

@@ -2629,7 +2629,7 @@ func (s *workflowClientTestSuite) TestGetWorkflowHistoryWithOptions() {
 		requestValidator  func(req *shared.GetWorkflowExecutionHistoryRequest)
 		rpcError          error
 		response          *shared.GetWorkflowExecutionHistoryResponse
-		responseValidator func(iter HistoryEventIterator, err error)
+		responseValidator func(iter HistoryEventIterator)
 	}{
 		{
 			name: "success without query consistency level",
@@ -2657,8 +2657,7 @@ func (s *workflowClientTestSuite) TestGetWorkflowHistoryWithOptions() {
 				},
 				NextPageToken: nil,
 			},
-			responseValidator: func(iter HistoryEventIterator, err error) {
-				s.NoError(err)
+			responseValidator: func(iter HistoryEventIterator) {
 				s.NotNil(iter)
 				s.True(iter.HasNext())
 				event, nextErr := iter.Next()
@@ -2693,8 +2692,7 @@ func (s *workflowClientTestSuite) TestGetWorkflowHistoryWithOptions() {
 				},
 				NextPageToken: nil,
 			},
-			responseValidator: func(iter HistoryEventIterator, err error) {
-				s.NoError(err)
+			responseValidator: func(iter HistoryEventIterator) {
 				s.NotNil(iter)
 				s.True(iter.HasNext())
 				event, nextErr := iter.Next()
@@ -2729,8 +2727,7 @@ func (s *workflowClientTestSuite) TestGetWorkflowHistoryWithOptions() {
 				},
 				NextPageToken: nil,
 			},
-			responseValidator: func(iter HistoryEventIterator, err error) {
-				s.NoError(err)
+			responseValidator: func(iter HistoryEventIterator) {
 				s.NotNil(iter)
 				s.True(iter.HasNext())
 				event, nextErr := iter.Next()
@@ -2768,8 +2765,7 @@ func (s *workflowClientTestSuite) TestGetWorkflowHistoryWithOptions() {
 				},
 				NextPageToken: nil,
 			},
-			responseValidator: func(iter HistoryEventIterator, err error) {
-				s.NoError(err)
+			responseValidator: func(iter HistoryEventIterator) {
 				s.NotNil(iter)
 
 				// Check that the iterator returns all events in order
@@ -2795,8 +2791,7 @@ func (s *workflowClientTestSuite) TestGetWorkflowHistoryWithOptions() {
 			requestValidator: func(req *shared.GetWorkflowExecutionHistoryRequest) {},
 			rpcError:         &shared.AccessDeniedError{},
 			response:         nil,
-			responseValidator: func(iter HistoryEventIterator, err error) {
-				s.NoError(err, "should not return error immediately")
+			responseValidator: func(iter HistoryEventIterator) {
 				s.NotNil(iter, "iterator should be returned")
 
 				// Error should be returned when iterator is used
@@ -2817,8 +2812,8 @@ func (s *workflowClientTestSuite) TestGetWorkflowHistoryWithOptions() {
 				}).
 				Return(tt.response, tt.rpcError)
 
-			iter, err := s.client.GetWorkflowHistoryWithOptions(context.Background(), tt.request)
-			tt.responseValidator(iter, err)
+			iter := s.client.GetWorkflowHistoryWithOptions(context.Background(), tt.request)
+			tt.responseValidator(iter)
 		})
 	}
 }