Add helper function for GetBinaryChecksum (#991)

Author: vancexu

internal/internal_task_handlers_test.go

@@ -358,9 +358,9 @@ func (t *TaskHandlersTestSuite) TestWorkflowTask_BinaryChecksum() {
 	t.NotNil(response)
 	t.Equal(1, len(response.Decisions))
 	t.Equal(s.DecisionTypeCompleteWorkflowExecution, response.Decisions[0].GetDecisionType())
-	checksumsJSON := string(response.Decisions[0].CompleteWorkflowExecutionDecisionAttributes.Result)
+	checksumsBytes := response.Decisions[0].CompleteWorkflowExecutionDecisionAttributes.Result
 	var checksums []string
-	json.Unmarshal([]byte(checksumsJSON), &checksums)
+	json.Unmarshal(checksumsBytes, &checksums)
 	t.Equal(3, len(checksums))
 	t.Equal("chck1", checksums[0])
 	t.Equal("chck2", checksums[1])

internal/internal_worker_interfaces_test.go

@@ -112,13 +112,13 @@ func querySignalWorkflowFunc(ctx Context, numSignals int) error {
 	return nil
 }
 
-func binaryChecksumWorkflowFunc(ctx Context) ([]*string, error) {
-	var result []*string
-	result = append(result, GetWorkflowInfo(ctx).BinaryChecksum)
+func binaryChecksumWorkflowFunc(ctx Context) ([]string, error) {
+	var result []string
+	result = append(result, GetWorkflowInfo(ctx).GetBinaryChecksum())
 	Sleep(ctx, time.Hour)
-	result = append(result, GetWorkflowInfo(ctx).BinaryChecksum)
+	result = append(result, GetWorkflowInfo(ctx).GetBinaryChecksum())
 	Sleep(ctx, time.Hour)
-	result = append(result, GetWorkflowInfo(ctx).BinaryChecksum)
+	result = append(result, GetWorkflowInfo(ctx).GetBinaryChecksum())
 	return result, nil
 }
 

internal/workflow.go

@@ -740,6 +740,13 @@ type WorkflowInfo struct {
 	BinaryChecksum                      *string
 }
 
+func (wInfo *WorkflowInfo) GetBinaryChecksum() string {
+	if wInfo.BinaryChecksum == nil {
+		return getBinaryChecksum()
+	}
+	return *wInfo.BinaryChecksum
+}
+
 // GetWorkflowInfo extracts info of a current workflow from a context.
 func GetWorkflowInfo(ctx Context) *WorkflowInfo {
 	i := getWorkflowInterceptor(ctx)

test/integration_test.go

@@ -61,7 +61,7 @@ const (
 	ctxTimeout                 = 15 * time.Second
 	domainName                 = "integration-test-domain"
 	domainCacheRefreshInterval = 20 * time.Second
-	testContextKey			   = "test-context-key"
+	testContextKey             = "test-context-key"
 )
 
 func TestIntegrationSuite(t *testing.T) {
@@ -149,7 +149,7 @@ func (ts *IntegrationTestSuite) SetupTest() {
 		DisableStickyExecution:            ts.config.IsStickyOff,
 		Logger:                            logger,
 		WorkflowInterceptorChainFactories: []interceptors.WorkflowInterceptorFactory{ts.tracer},
-		ContextPropagators:     []workflow.ContextPropagator{NewStringMapPropagator([]string{testContextKey})},
+		ContextPropagators:                []workflow.ContextPropagator{NewStringMapPropagator([]string{testContextKey})},
 	}
 	ts.worker = worker.New(ts.rpcClient.Interface, domainName, ts.taskListName, options)
 	ts.registerWorkflowsAndActivities(ts.worker)

test/test_utils.go

@@ -36,7 +36,7 @@ import (
 
 type (
 	// Config contains the integration test configuration
-	 Config struct {
+	Config struct {
 		ServiceAddr string
 		ServiceName string
 		IsStickyOff bool