Minor test enhancement for local activity retries (#1069)

While looking into a user's issue with local activities retrying and not seeming to honor NonRetriableErrorReasons,
I noticed that we had no tests for non-retriable local activity errors.

So this test now mimics `Test_ActivityRetry`, but with local activities.

Author: Groxx

internal/internal_workflow_testsuite_test.go

@@ -2398,16 +2398,23 @@ func (s *WorkflowTestSuiteUnitTest) Test_ActivityHeartbeatRetry() {
 }
 
 func (s *WorkflowTestSuiteUnitTest) Test_LocalActivityRetry() {
+	nonretriableCount := 0
+	nonretriableFn := func(ctx context.Context) (string, error) {
+		nonretriableCount++
+		return "", NewCustomError("bad-bug")
+	}
 
-	localActivityFn := func(ctx context.Context) (int32, error) {
+	retriableCount := 0
+	retriableFn := func(ctx context.Context) (string, error) {
+		retriableCount++
 		info := GetActivityInfo(ctx)
 		if info.Attempt < 2 {
-			return int32(-1), NewCustomError("bad-luck")
+			return "", NewCustomError("bad-luck")
 		}
-		return info.Attempt, nil
+		return "retry-done", nil
 	}
 
-	workflowFn := func(ctx Context) (int32, error) {
+	workflowFn := func(ctx Context) (string, error) {
 		lao := LocalActivityOptions{
 			ScheduleToCloseTimeout: time.Minute,
 			RetryPolicy: &RetryPolicy{
@@ -2421,10 +2428,15 @@ func (s *WorkflowTestSuiteUnitTest) Test_LocalActivityRetry() {
 		}
 		ctx = WithLocalActivityOptions(ctx, lao)
 
-		var result int32
-		err := ExecuteLocalActivity(ctx, localActivityFn).Get(ctx, &result)
+		err := ExecuteLocalActivity(ctx, nonretriableFn).Get(ctx, nil)
+		badBug, ok := err.(*CustomError)
+		s.True(ok)
+		s.Equal("bad-bug", badBug.Reason())
+
+		var result string
+		err = ExecuteLocalActivity(ctx, retriableFn).Get(ctx, &result)
 		if err != nil {
-			return int32(-1), err
+			return "", err
 		}
 		return result, nil
 	}
@@ -2435,9 +2447,11 @@ func (s *WorkflowTestSuiteUnitTest) Test_LocalActivityRetry() {
 
 	s.True(env.IsWorkflowCompleted())
 	s.NoError(env.GetWorkflowError())
-	var result int32
+	var result string
 	s.NoError(env.GetWorkflowResult(&result))
-	s.Equal(int32(2), result)
+	s.Equal("retry-done", result)
+	s.Equal(1, nonretriableCount)
+	s.Equal(3, retriableCount)
 }
 
 func (s *WorkflowTestSuiteUnitTest) Test_LocalActivityRetryOnCancel() {