Skip to content

Commit 83f9e2b

Browse files
author
Mandy Chen
committed
add always and test
1 parent 9ee0f06 commit 83f9e2b

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

.github/workflows/ci-checks.yml

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ jobs:
2424
run: docker compose -f docker/github_actions/docker-compose.yml run unit-test bash -c "make unit_test && ./scripts/gen_coverage_metadata.sh .build/metadata.txt"
2525

2626
- name: Upload coverage artifacts
27+
if: always()
2728
uses: actions/upload-artifact@v4
2829
with:
2930
name: go-unit-test-coverage
@@ -77,6 +78,7 @@ jobs:
7778
docker compose -f docker/github_actions/docker-compose.yml run integ-test bash -c "make integ_test_sticky_off"
7879
7980
- name: Upload coverage artifacts
81+
if: always()
8082
uses: actions/upload-artifact@v4
8183
with:
8284
name: go-integration-sticky-off-coverage
@@ -108,6 +110,7 @@ jobs:
108110
docker compose -f docker/github_actions/docker-compose.yml run integ-test bash -c "make integ_test_sticky_on"
109111
110112
- name: Upload coverage artifacts
113+
if: always()
111114
uses: actions/upload-artifact@v4
112115
with:
113116
name: go-integration-sticky-on-coverage
@@ -133,12 +136,13 @@ jobs:
133136
- name: Run integration test gRPC
134137
uses: nick-fields/retry@v3
135138
with:
136-
max_attempts: 2
139+
max_attempts: 1
137140
timeout_minutes: 30
138141
command: |
139-
docker compose -f docker/github_actions/docker-compose.yml run integ-test-grpc bash -c "make integ_test_grpc"
142+
docker compose -f docker/github_actions/docker-compose.yml run integ-test-grpc bash -c "make integ_test_grpc && exit 1"
140143
141144
- name: Upload coverage artifacts
145+
if: always()
142146
uses: actions/upload-artifact@v4
143147
with:
144148
name: go-integration-grpc-coverage

0 commit comments

Comments
 (0)