Move ErrorDetailsValues to error.go (#1008)

Author: vytautas-karpavicius

internal/error.go

@@ -24,6 +24,7 @@ package internal
 import (
 	"errors"
 	"fmt"
+	"reflect"
 	"strings"
 
 	"go.uber.org/cadence/.gen/go/shared"
@@ -133,6 +134,9 @@ type (
 
 	// UnknownExternalWorkflowExecutionError can be returned when external workflow doesn't exist
 	UnknownExternalWorkflowExecutionError struct{}
+
+	// ErrorDetailsValues is a type alias used hold error details objects.
+	ErrorDetailsValues []interface{}
 )
 
 const (
@@ -375,3 +379,28 @@ func newUnknownExternalWorkflowExecutionError() *UnknownExternalWorkflowExecutio
 func (e *UnknownExternalWorkflowExecutionError) Error() string {
 	return "UnknownExternalWorkflowExecution"
 }
+
+// HasValues return whether there are values.
+func (b ErrorDetailsValues) HasValues() bool {
+	return b != nil && len(b) != 0
+}
+
+// Get extract data from encoded data to desired value type. valuePtr is pointer to the actual value type.
+func (b ErrorDetailsValues) Get(valuePtr ...interface{}) error {
+	if !b.HasValues() {
+		return ErrNoData
+	}
+	if len(valuePtr) > len(b) {
+		return ErrTooManyArg
+	}
+	for i, item := range valuePtr {
+		target := reflect.ValueOf(item).Elem()
+		val := reflect.ValueOf(b[i])
+		if !val.Type().AssignableTo(target.Type()) {
+			return fmt.Errorf(
+				"unable to decode argument: cannot set %v value to %v field", val.Type(), target.Type())
+		}
+		target.Set(val)
+	}
+	return nil
+}

internal/workflow_testsuite.go

@@ -40,9 +40,6 @@ type (
 		dataConverter DataConverter
 	}
 
-	// ErrorDetailsValues is a type alias used hold error details objects.
-	ErrorDetailsValues []interface{}
-
 	// WorkflowTestSuite is the test suite to run unit tests for workflow/activity.
 	WorkflowTestSuite struct {
 		logger   *zap.Logger
@@ -92,31 +89,6 @@ func (b EncodedValues) HasValues() bool {
 	return b.values != nil
 }
 
-// Get extract data from encoded data to desired value type. valuePtr is pointer to the actual value type.
-func (b ErrorDetailsValues) Get(valuePtr ...interface{}) error {
-	if !b.HasValues() {
-		return ErrNoData
-	}
-	if len(valuePtr) > len(b) {
-		return ErrTooManyArg
-	}
-	for i, item := range valuePtr {
-		target := reflect.ValueOf(item).Elem()
-		val := reflect.ValueOf(b[i])
-		if !val.Type().AssignableTo(target.Type()) {
-			return fmt.Errorf(
-				"unable to decode argument: cannot set %v value to %v field", val.Type(), target.Type())
-		}
-		target.Set(val)
-	}
-	return nil
-}
-
-// HasValues return whether there are values.
-func (b ErrorDetailsValues) HasValues() bool {
-	return b != nil && len(b) != 0
-}
-
 // NewTestWorkflowEnvironment creates a new instance of TestWorkflowEnvironment. Use the returned TestWorkflowEnvironment
 // to run your workflow in the test environment.
 func (s *WorkflowTestSuite) NewTestWorkflowEnvironment() *TestWorkflowEnvironment {