Skip to content

Commit a81c86a

Browse files
authored
do not break if local dispatch fails (#1035)
1 parent 910e707 commit a81c86a

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

internal/internal_task_pollers.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -458,14 +458,14 @@ func (wtp *workflowTaskPoller) RespondTaskCompleted(completedRequest interface{}
458458
WorkflowExecution: task.WorkflowExecution,
459459
WorkflowType: task.WorkflowType,
460460
}
461-
if !wtp.ldaTunnel.sendTask(activityTask) {
462-
// all pollers are busy - no room to optimize the remaining dispatches
461+
if wtp.ldaTunnel.sendTask(activityTask) {
462+
wtp.metricsScope.Counter(metrics.ActivityLocalDispatchSucceedCounter).Inc(1)
463+
decision.ScheduleActivityTaskDecisionAttributes.RequestLocalDispatch = common.BoolPtr(true)
464+
activityTasks = append(activityTasks, activityTask)
465+
} else {
466+
// all pollers are busy - no room to optimize
463467
wtp.metricsScope.Counter(metrics.ActivityLocalDispatchFailedCounter).Inc(1)
464-
break
465468
}
466-
wtp.metricsScope.Counter(metrics.ActivityLocalDispatchSucceedCounter).Inc(1)
467-
decision.ScheduleActivityTaskDecisionAttributes.RequestLocalDispatch = common.BoolPtr(true)
468-
activityTasks = append(activityTasks, activityTask)
469469
}
470470
}
471471
}

0 commit comments

Comments
 (0)