Fix logging and metric tags used by shadow worker (#1076)

Author: yycptt

internal/workflow_shadower_worker.go

@@ -66,6 +66,12 @@ func newShadowWorker(
 		// include domain name in tasklist to avoid confliction
 		// since all shadow workflow will be run in a single system domain
 		params.TaskList = generateShadowTaskList(domain, params.TaskList)
+		if params.MetricsScope != nil {
+			params.MetricsScope = tagScope(params.MetricsScope, tagTaskList, params.TaskList)
+		}
+		if params.Logger != nil {
+			params.Logger = params.Logger.With(zap.String(tagTaskList, params.TaskList))
+		}
 	}
 
 	params.UserContext = context.WithValue(params.UserContext, serviceClientContextKey, service)

internal/workflow_shadower_worker_test.go

@@ -96,7 +96,8 @@ func (s *shadowWorkerSuite) TestStartShadowWorker_Failed_ShadowOptionNotSpecifie
 		testDomain,
 		nil,
 		workerExecutionParameters{
-			TaskList: testTaskList,
+			TaskList:    testTaskList,
+			UserContext: context.Background(),
 		},
 		newRegistry(),
 	)
@@ -112,7 +113,8 @@ func (s *shadowWorkerSuite) TestStartShadowWorker_Failed_InvalidShadowOption() {
 			Mode: ShadowModeContinuous, // exit condition is not specified
 		},
 		workerExecutionParameters{
-			TaskList: testTaskList,
+			TaskList:    testTaskList,
+			UserContext: context.Background(),
 		},
 		newRegistry(),
 	)
@@ -130,8 +132,9 @@ func (s *shadowWorkerSuite) TestStartShadowWorker_Failed_DomainNotExist() {
 		testDomain,
 		&ShadowOptions{},
 		workerExecutionParameters{
-			TaskList: testTaskList,
-			Logger:   zaptest.NewLogger(s.T()),
+			TaskList:    testTaskList,
+			Logger:      zaptest.NewLogger(s.T()),
+			UserContext: context.Background(),
 		},
 		newRegistry(),
 	)
@@ -148,7 +151,9 @@ func (s *shadowWorkerSuite) TestStartShadowWorker_Failed_TaskListNotSpecified()
 		s.mockService,
 		testDomain,
 		&ShadowOptions{},
-		workerExecutionParameters{},
+		workerExecutionParameters{
+			UserContext: context.Background(),
+		},
 		newRegistry(),
 	)
 
@@ -169,7 +174,8 @@ func (s *shadowWorkerSuite) TestStartShadowWorker_Failed_StartWorkflowError() {
 		testDomain,
 		&ShadowOptions{},
 		workerExecutionParameters{
-			TaskList: testTaskList,
+			TaskList:    testTaskList,
+			UserContext: context.Background(),
 		},
 		newRegistry(),
 	)
@@ -211,7 +217,8 @@ func (s *shadowWorkerSuite) TestStartShadowWorker_Succeed() {
 			Concurrency:   concurrency,
 		},
 		workerExecutionParameters{
-			TaskList: testTaskList,
+			TaskList:    testTaskList,
+			UserContext: context.Background(),
 		},
 		newRegistry(),
 	)